-
-
Notifications
You must be signed in to change notification settings - Fork 509
Rocm7.1 index update #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rocm7.1 index update #1532
Conversation
Summary of ChangesHello @NeuralFault, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the ROCm index for both ComfyUI and SDWebForge (Forge/reForge) from Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the ROCm index to rocm7.1 for ComfyUI and SDWebForge, aligning with the latest stable PyTorch installation requirements. The changes are straightforward and address the issue described. I have one suggestion to improve consistency by updating a related default parameter in BaseGitPackage.cs to prevent potential issues with other packages that might rely on it.
| TorchaudioVersion = " ", // Request torchaudio without a specific version | ||
| CudaIndex = isLegacyNvidia ? "cu126" : "cu130", | ||
| RocmIndex = "rocm6.4", | ||
| RocmIndex = "rocm7.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated ROCm index for ComfyUI and Forge/reForge to rocm7.1 for latest stable Pytorch installation.
As attempting rocm6.4 still with pytorch during package installs results in generic pytorch installation instead.