Skip to content

Conversation

@NeuralFault
Copy link
Contributor

Updated ROCm index for ComfyUI and Forge/reForge to rocm7.1 for latest stable Pytorch installation.
As attempting rocm6.4 still with pytorch during package installs results in generic pytorch installation instead.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @NeuralFault, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the ROCm index for both ComfyUI and SDWebForge (Forge/reForge) from rocm6.4 to rocm7.1. The primary goal of this change is to ensure that these applications correctly utilize the latest stable PyTorch installations, thereby preventing issues where an outdated ROCm index might lead to a less optimized, generic PyTorch setup.

Highlights

  • ROCm Index Update for ComfyUI: The RocmIndex configuration for ComfyUI has been updated from rocm6.4 to rocm7.1. This change ensures compatibility with the latest stable PyTorch installations, preventing fallback to generic PyTorch setups.
  • ROCm Index Update for SDWebForge: The RocmIndex configuration for SDWebForge (Forge/reForge) has been updated from rocm6.4 to rocm7.1. This update is essential for proper integration with the latest stable PyTorch versions, avoiding generic installations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the ROCm index to rocm7.1 for ComfyUI and SDWebForge, aligning with the latest stable PyTorch installation requirements. The changes are straightforward and address the issue described. I have one suggestion to improve consistency by updating a related default parameter in BaseGitPackage.cs to prevent potential issues with other packages that might rely on it.

TorchaudioVersion = " ", // Request torchaudio without a specific version
CudaIndex = isLegacyNvidia ? "cu126" : "cu130",
RocmIndex = "rocm6.4",
RocmIndex = "rocm7.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This update to rocm7.1 is correct. To maintain consistency and avoid potential issues with other packages using default values, consider also updating the default rocmIndex parameter in the GetTorchPipArgs method in BaseGitPackage.cs from rocm6.4 to rocm7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant