Skip to content
/ server Public

Commit d0acb8e

Browse files
MDEV-24813 [demo] Revert innodb changes introduced in the grandparent commit
Should have no test failures now.
1 parent 95e62e1 commit d0acb8e

File tree

5 files changed

+3
-31
lines changed

5 files changed

+3
-31
lines changed

mysql-test/main/disabled.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,4 @@ mysql_embedded : Bug#12561297 2011-05-14 Anitha Dependent on PB2 chang
1616
file_contents : MDEV-6526 these files are not installed anymore
1717
max_statement_time : cannot possibly work, depends on timing
1818
partition_open_files_limit : open_files_limit check broken by MDEV-18360
19+
innodb_full_scan : MDEV-24813 WIP

storage/innobase/handler/ha_innodb.cc

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15899,25 +15899,6 @@ ha_innobase::extra(
1589915899
return(0);
1590015900
}
1590115901

15902-
int
15903-
ha_innobase::extra_opt(
15904-
/*===============*/
15905-
enum ha_extra_function operation,
15906-
/*!< in: HA_EXTRA_FLUSH or some other flag */
15907-
ulong arg)
15908-
{
15909-
switch (operation) {
15910-
/* TODO: ignoring LIMIT for now */
15911-
case HA_EXTRA_FULL_SCAN:
15912-
m_prebuilt->full_table_scan= true;
15913-
break;
15914-
default:/* Do nothing */
15915-
;
15916-
}
15917-
15918-
return(0);
15919-
}
15920-
1592115902
/**
1592215903
MySQL calls this method at the end of each statement */
1592315904
int
@@ -15938,7 +15919,6 @@ ha_innobase::reset()
1593815919
m_prebuilt->autoinc_last_value = 0;
1593915920

1594015921
m_prebuilt->skip_locked = false;
15941-
m_prebuilt->full_table_scan = false;
1594215922
return(0);
1594315923
}
1594415924

storage/innobase/handler/ha_innodb.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,6 @@ class ha_innobase final : public handler
177177

178178
int extra(ha_extra_function operation) override;
179179

180-
int extra_opt(ha_extra_function operation, ulong arg) override;
181-
182180
int reset() override;
183181

184182
int external_lock(THD *thd, int lock_type) override;

storage/innobase/include/row0mysql.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -695,11 +695,6 @@ struct row_prebuilt_t {
695695
/** The MySQL table object */
696696
TABLE* m_mysql_table;
697697

698-
bool full_table_scan; /*!< Whether the full table will need to be
699-
scanned. Set when the sql layer passes NULL cond in
700-
cond_push. Will cause to use X/S locks in select rather than
701-
IX/IS locks */
702-
703698
/** Get template by dict_table_t::cols[] number */
704699
const mysql_row_templ_t* get_template_by_col(ulint col) const
705700
{

storage/innobase/row/row0sel.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4718,10 +4718,8 @@ row_search_mvcc(
47184718
} else {
47194719
wait_table_again:
47204720
err = lock_table(prebuilt->table, nullptr,
4721-
prebuilt->full_table_scan ?
4722-
prebuilt->select_lock_type :
4723-
(prebuilt->select_lock_type == LOCK_S
4724-
? LOCK_IS : LOCK_IX), thr);
4721+
prebuilt->select_lock_type == LOCK_S
4722+
? LOCK_IS : LOCK_IX, thr);
47254723

47264724
if (err != DB_SUCCESS) {
47274725

0 commit comments

Comments
 (0)