Csla 9.1.0 - Properties are not set during OnSetState

[ajohnstone-ks]

We've had a few regression bugs pop up in our first release using Csla 9; the issue seems to be that during the OnSetState invocation, the Csla managed properties have not yet been loaded. We had been using OnSetState to do some other sets on the client based on the values in the BO, but these are not working any longer.

Here is a repo of the problem; as you can see in the console output MyString is empty during OnSetState but it does eventually get set (just too late for our purposes). Is this intentional, or a bug? If its intentional, where can we put code that needs to run after deserializable (and only on the logical client)?

EDIT: Hmm it seems like this hasn't worked since we moved to Csla 6; not sure how it escaped notice until now.

https://github.com/ajohnstone-ks/CslaOnSetStateIssue

[rockfordlhotka]

I'm "glad" it isn't new with v9 as that would have been puzzling. I have no doubt it changed in v6 - a lot changed then.

I am 99.99% sure we added a way to know that serialization is complete. That might have been in v10, or v9, I'm not sure. @StefanOssendorf might remember?

[rockfordlhotka]

If anyone is curious, here's the prompt I provided to sonnet via claude code:

"search the git history to see when we implemented ondeserialized notifiation - notification that serialization of an object (or object graph) is complete. Or maybe use the 'gh' command and search PRs - either way or both."

[rockfordlhotka]

You'd have to look through the issues history (or have an AI do it) to figure out why we changed things.

In any case, newer serializers like the super-fast one @JasonBock has been working on don't use the same low-level plumbing as mobileformatter, but (I think or at least hope) they still honor the higher level ondeserialized notification.

[ajohnstone-ks]

@rockfordlhotka Actually that made me remember; in 6 OnDeserialized was gone, so I think I moved the code to OnSetState thinking it would be called after the bo's OnSetState. But i looking at it today the base method is empty, so maybe it never worked that way.

It looks like what we need is in Csla 10... but that's not really an option (we've already delayed releasing multiple times to deal with issues updating [not just Csla, Maui as well, it would fix some things and break others..])

Is it safe to implement ISerializationNotification on our BO to do what we need to?

[rockfordlhotka]

Is it safe to implement ISerializationNotification on our BO to do what we need to?

I think that's a good thing to try for sure.

[ajohnstone-ks]

Is it safe to implement ISerializationNotification on our BO to do what we need to?

I think that's a good thing to try for sure.

My concern with doing that is that then the implemenation in Csla.Core.BusinessBase would not be called, but in looking at what that does it seems the OnDeserialized was added back in the version of Csla 9 we're using, so I think we'll give that a try first. Thank you!