Skip to content

Commit 5f4146c

Browse files
r-sharpRoddy Sharpyaswant
authored
Umdp3 checker in python (#153)
* Adding initial files - created by Claude AI and Yash to begin investigations as to whether it's worked and how it can be improved. * The Python version runs - however output is nothing like the original and is to std out whereas the origianl wrote to std err. It's not clear if the Python version terminated after the first file with errors, or genuinely didn't spot the errors in the other files. Branch used to look for errors is : https://code.metoffice.gov.uk/svn/um/main/branches/dev/roddysharp/vn13.9_deliberate_umdp3_failures * Hacking the code to force 1 file per thread. This produces output for all the edited files. * Instrumenting the perl to count files... and the python to find files in trunk mode... * Refactor umdp3_check.py and add debug log files for compliance checks * adding the executable mode to the python file. * Adding some more debugging prints around repos selection in trunk/suite mode * rEMOVING (COMMENTING OUT) SOME OLDER DEBUG PRINTS * More debugging print statements to track what is added to extracts list * Moving the 'extracts' logic completely out of the suite/not suite umdp3_checkas I think Perl did it for both cases.. * Trying to tame the no. of files the Python version now looks at... * And fix the path prepend that I had to add for a trunk WC but fails for a Trunk in suite.. * Hopefully sorting the duplication of files listed for checking * Adding first draft of Sams bdiff object to fcm_bdiff.py * Adjusting Fortran keyword checking to Sam's improved methodology. Plus making the branch processing of files changes return a list. * Committing changes so UM rose-stem can extract my versions and use them... * Adding some basic unit tests for the Fortran checkers in umdp3.py * Adding some more basic unit tests for umdp3 * Adding a couple more basic unit tests... * More unit tests - almost done honest guv... * Final set of "Fortran" checking unit tests, lus a wee bit O tidying * Some tidying up, some 'moving about' of lists to a separate file for clarity and to reduce the size of umdp3.py. * Adding comments and todos * Adding latest non-working changes to re-write in umdp3_conformance.py * Trying to get git/github to sync everything - just blindly following hints as at every step it suggests something else... * Trying to get fcm_bdiff to work like git_bdiff... * removeing comments no longer reqd * sifting through the "boilerplate" to get something with a list of files reliably * Adding the "else: It's a branch" to check branch/main test functions * Bodging in changes to use some previous Fortran checks on files. * lets pretend we know how to use git n - it won't let me sync if I don't commit these changes, which I won't need at the end... * Basics of taking a 'peek' into the test results... * Hardwiring in some UMDP3 checks for testing * Removing some debug prints which make the output very messy * Fiddling and twiddling. Multiple style checkers in one conformance checker. Style checkers hold the list of files they check * Who knows - who cares ? Shaving the hamster * light refactoring for better error output * light refactoring part II * light refactoring part II * A whole lot of tidying and removing trailing whitespace * Tidying, and fixing the pytests to at least run * Final tidy - removing unused files and moving things to final resting place. * Update .gitignore The files I added some time ago are no longer there... * Update temp.txt Again, a file I thought I'd deleted prior to creating the pull request. * Delete .ipynb_checkpoints/README-checkpoint.md * Delete temp.txt * Fixing the pytest tests * Black sucks - I disagree with practically every change it has made. Some of which seem to be reversing line breaking it imposed last time I ran it. It also now makes more of these files fail flake8 and pylint -//Super// * removing a file that should never have been there. (for the second time) * Renaming things, to hopefully make the structure of the related files clearer. As requested by SciTech * trying to fix ruff errors I can't replicate, nor does github show them to me.... * Still trying.... * Moving comments because ruff is too stupid to cope with them * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/tests/test_umdp3.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/tests/test_umdp3.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/tests/test_umdp3.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/search_lists.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/tests/test_umdp3.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/checker_dispatch_tables.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/tests/test_umdp3.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/tests/test_umdp3.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update script_umdp3_checker/tests/test_umdp3.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> * Update fcm_bdiff/fcm_bdiff.py Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> --------- Co-authored-by: Roddy Sharp <roddy.sharp@cazld000021.spice.sc.metoffice.gov.uk> Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
1 parent c8f5a19 commit 5f4146c

16 files changed

+3846
-3476
lines changed

fcm_bdiff.py

Lines changed: 0 additions & 262 deletions
This file was deleted.

fcm_bdiff/__init__.py

Whitespace-only changes.

0 commit comments

Comments
 (0)