Skip to content

Making SharedArrayBuffer to be experimental#1759

Merged
chakrabot merged 1 commit into
chakra-core:masterfrom
akroshg:sab1
Oct 18, 2016
Merged

Making SharedArrayBuffer to be experimental#1759
chakrabot merged 1 commit into
chakra-core:masterfrom
akroshg:sab1

Conversation

@akroshg
Copy link
Copy Markdown
Contributor

@akroshg akroshg commented Oct 18, 2016

No description provided.

@akroshg
Copy link
Copy Markdown
Contributor Author

akroshg commented Oct 18, 2016

@agarwal-sandeep @aneeshdk - please review.

Comment thread lib/Common/ConfigFlagsList.h Outdated
#define DEFAULT_CONFIG_ES7ValuesEntries (true)
#define DEFAULT_CONFIG_ESObjectGetOwnPropertyDescriptors (true)

#ifdef DEFAULT_DISABLE_ESSharedArrayBuffer
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT_DISABLE_ESSharedArrayBuffer [](start = 7, length = 35)

COMPILE_DISABLE_ESSharedArrayBuffer

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed that.

@aneeshdk
Copy link
Copy Markdown
Contributor

:shipit:

@chakrabot chakrabot merged commit 8c8dd27 into chakra-core:master Oct 18, 2016
chakrabot pushed a commit that referenced this pull request Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants