Skip to content

17-07 ChakraCore servicing release#3341

Merged
chakrabot merged 12 commits into
release/1.5from
pr/akroshg/1707
Jul 13, 2017
Merged

17-07 ChakraCore servicing release#3341
chakrabot merged 12 commits into
release/1.5from
pr/akroshg/1707

Conversation

@akroshg

@akroshg akroshg commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

akroshg and others added 9 commits July 10, 2017 16:43
… invalid index

Pre-reserve potentially needed slots upfront.
…re conversion of the source value can cause implicit calls. For BailOutOnImplicitCalls, check implicit call bit on return from the conversion helper. For BailOutOnArrayAccessHelperCall, bail out instead of calling the conversion helper.
…en new pointer symbol and existing object type spec info. If there is a mismatch, then stale ObjTypeSpecFldInfo may lead to jitted code that accesses a bad address, so disable optimization of this load/store.
…erpreter

Prevents having to use the interpreterStackFrame outside of InterpreterHelper
@akroshg

akroshg commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

@rajatd @suwc @Cellule @pleath @jianchun Please have a look

@akroshg

akroshg commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

@Penguinwizzard @kfarnung FYI...

@suwc

suwc commented Jul 13, 2017

Copy link
Copy Markdown

LGTM. [CVE-2017-8598]

@jianchun

Copy link
Copy Markdown

LGTM (8606, 8607, 8608)

@Cellule

Cellule commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

LGTM [CVE-2017-8603] [CVE-2017-8604]

@rajatd

rajatd commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

LGTM wrt CVE-2017-8610

@MSLaguana

Copy link
Copy Markdown
Contributor

Looks like there's an asmjs test failure on osx, and some prefast warnings on windows, in addition to copyright/line ending complaints.

@akroshg

akroshg commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

@MSLaguana yes working on it.

@pleath

pleath commented Jul 13, 2017 via email

Copy link
Copy Markdown
Contributor

@akroshg

akroshg commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

@pleath yes.
looking at OSX problem now.

@akroshg

akroshg commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

For asmJs @Cellule can you take a look?

@Cellule

Cellule commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

We should add exclude_xplat to my new asm.js test. It is hitting issue #2378

@chakrabot chakrabot merged commit 9940903 into release/1.5 Jul 13, 2017
chakrabot pushed a commit that referenced this pull request Jul 13, 2017
@akroshg

akroshg commented Jul 13, 2017

Copy link
Copy Markdown
Contributor Author

Thanks guys!

chakrabot pushed a commit that referenced this pull request Jul 13, 2017
chakrabot pushed a commit that referenced this pull request Jul 13, 2017
chakrabot pushed a commit that referenced this pull request Jul 13, 2017
@rajatd rajatd mentioned this pull request Jul 14, 2017
@obastemur obastemur deleted the pr/akroshg/1707 branch January 30, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants