Skip to content

Enable Wasm SignExtend operators by default#5136

Merged
chakrabot merged 1 commit into
chakra-core:masterfrom
Cellule:wasm/sign_extend
May 11, 2018
Merged

Enable Wasm SignExtend operators by default#5136
chakrabot merged 1 commit into
chakra-core:masterfrom
Cellule:wasm/sign_extend

Conversation

@Cellule
Copy link
Copy Markdown
Contributor

@Cellule Cellule commented May 11, 2018

This change is Reviewable

@Cellule Cellule requested a review from MikeHolman May 11, 2018 17:11
@Cellule Cellule self-assigned this May 11, 2018
Comment thread lib/WasmReader/WasmParseTree.cpp Outdated
bool IsEnabled()
{
#ifdef ENABLE_WASM
return CONFIG_FLAG(WasmNontrapping);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong flag

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops bad copy/paste

@Cellule Cellule force-pushed the wasm/sign_extend branch from 482d83f to 53d4354 Compare May 11, 2018 21:54
@chakrabot chakrabot merged commit 53d4354 into chakra-core:master May 11, 2018
chakrabot pushed a commit that referenced this pull request May 11, 2018
Merge pull request #5136 from Cellule:wasm/sign_extend
@Cellule Cellule deleted the wasm/sign_extend branch May 12, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants