Add support for revive as lintTool

[mgechev]

Introduces support for revive. Revive is an extensible, configurable, and faster alternative of golint.

[ramya-rao-a]

Users might want to use the ${workspaceFolder} or ${workspaceRoot} variables for the config file. We support this for the config file used by gometalinter. You might want to do something similar for revive.

See https://github.com/Microsoft/vscode-go/blob/master/src/goLint.ts#L67

[mgechev]

Just updated the readme & tested the ${workspaceRoot}/${workspaceFolder} support locally. Everything seems to be functioning correctly.

[wolfeidau]

@mgechev are you going to fix this feedback so we can try it out?

Keen to use this!

Cheers

[ramya-rao-a]

Thanks for the PR!

I'll update this thread soon with steps to try this out before I release the next update.

[mgechev]

Sounds good! I'm already using it in my project:

Would definitely verify again once you share the steps.

[ramya-rao-a]

To test this,

• Download https://github.com/Microsoft/vscode-go/blob/master/Go-latest.vsix
• Run code --install-extension Go-latest.vsix
• If the above fails with Error: end of central directory record signature not found, then clone this repo and use the Go-latest.vsix file from the cloned repo
• Reload VS Code
• Change the go.lintTool setting to revive

[mgechev]

@ramya-rao-a verified that everything works as expected. Tested the config file as well 💯