ALFMOB-162: Code review

Author: JoaoPinhoMinder

Alfie/Alfie/Views/ProductDetails/ProductDetailsViewModel.swift

@@ -5,6 +5,7 @@ import Models
 import SharedUI
 import StyleGuide
 
+// swiftlint:disable file_length
 final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
     private let dependencies: ProductDetailsDependencyContainer
     // In case we already have a full or partial product to show while fetching
@@ -94,11 +95,11 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
     }
 
     private var hasColorSelected: Bool {
-        colorSelectionConfiguration.items.count > 1 ? selectedVariant?.colour != nil : true
+        !colorSelectionConfiguration.items.isEmpty ? selectedVariant?.colour != nil : true
     }
 
     private var hasSizeSelected: Bool {
-        sizingSelectionConfiguration.items.count > 1 ? selectedVariant?.size != nil : true
+        !sizingSelectionConfiguration.items.isEmpty ? selectedVariant?.size != nil : true
     }
 
     init(
@@ -436,4 +437,4 @@ final class ProductDetailsViewModel: ProductDetailsViewModelProtocol {
 
         return SelectedProduct(product: product, selectedVariant: selectedVariant)
     }
-} // swiftlint:disable:this file_length
+}

Alfie/AlfieKit/Sources/Models/Models/Product/SelectedProduct/SelectedProduct.swift

@@ -3,47 +3,22 @@ import Foundation
 public class SelectedProduct: Identifiable, Hashable {
     public let product: Product
     public let selectedVariant: Product.Variant
-
-    public var id: String {
-        "\(product.id)-\(selectedVariant.sku)"
-    }
-
-    public var name: String {
-        product.name
-    }
-
-    public var brand: Brand {
-        product.brand
-    }
-
-    public var size: Product.ProductSize? {
-        selectedVariant.size
-    }
-
-    public var colour: Product.Colour? {
-        selectedVariant.colour
-    }
-
-    public var stock: Int {
-        selectedVariant.stock
-    }
-
-    public var price: Price {
-        selectedVariant.price
-    }
-
-    public var media: [Media] {
-        colour?.media ?? []
-    }
+    public var id: String { "\(product.id)-\(selectedVariant.sku)" }
+    public var name: String { product.name }
+    public var brand: Brand { product.brand }
+    public var size: Product.ProductSize? { selectedVariant.size }
+    public var colour: Product.Colour? { selectedVariant.colour }
+    public var stock: Int { selectedVariant.stock }
+    public var price: Price { selectedVariant.price }
+    public var media: [Media] { colour?.media ?? [] }
 
     public init(product: Product, selectedVariant: Product.Variant? = nil) {
         self.product = product
         self.selectedVariant = selectedVariant ?? product.defaultVariant
     }
 
     public static func == (lhs: SelectedProduct, rhs: SelectedProduct) -> Bool {
-        lhs.product == rhs.product
-        && lhs.selectedVariant == rhs.selectedVariant
+        lhs.product == rhs.product && lhs.selectedVariant == rhs.selectedVariant
     }
 
     public func hash(into hasher: inout Hasher) {

Alfie/AlfieKit/Sources/Models/Models/Product/SelectedProduct/WishlistProduct.swift

@@ -1,10 +1,7 @@
 import Foundation
 
 public class WishlistProduct: SelectedProduct {
-    override
-    public var id: String {
-        "\(product.id)-\(colour?.id ?? "no colour")"
-    }
+    override public var id: String { "\(product.id)-\(colour?.id ?? "no colour")" }
 
     public init(selectedProduct: SelectedProduct) {
         let updatedVariant = Product.Variant(