Fix build warnings (found with gcc -Wall)

Author: mhochsteger

libsrc/core/array.hpp

@@ -842,6 +842,9 @@ namespace ngcore
     NETGEN_INLINE void NothingToDelete () 
     { 
       mem_to_delete = nullptr;
+
+      // this memory is not managed by the Array anymore, so set the memory usage to 0
+      mt.Free(sizeof(T)*allocsize);
     }
 
     /// Change logical size. If necessary, do reallocation. Keeps contents.

libsrc/csg/csgeom.cpp

@@ -1211,7 +1211,7 @@ namespace netgen
 	PrintMessage (2, "Object ", i, " has ", tams->GetNT(), " triangles");
       }
       }
-    catch (exception)
+    catch (const std::exception &)
       {
 	cerr << "*************************************************************" << endl
 	     << "****   out of memory problem in CSG visualization        ****" << endl

libsrc/general/table.cpp

@@ -109,7 +109,7 @@ namespace netgen
       {
 	void * p = new char [(line.maxsize+5) * elsize];
 
-        if (line.maxsize*elsize)
+        if (line.maxsize && elsize)
           memcpy (p, line.col, line.maxsize * elsize);
 	delete [] (char*)line.col;
 

libsrc/interface/nginterface_v2.cpp

@@ -1041,7 +1041,7 @@ namespace netgen
                                                         build_searchtree);
               return ind - 1;
             }
-          catch(NgException e) // quads not implemented curved yet
+          catch(const NgException & e) // quads not implemented curved yet
             {
           for (SegmentIndex si = 0; si < mesh->GetNSeg(); si++)
             {

libsrc/interface/readuser.cpp

@@ -301,7 +301,7 @@ namespace netgen
                     in >> name;
                     cout << IM(3)  << len << " element are in group " << name << endl;
                     int hi, index;
-                    int fdnr, ednr;
+                    int fdnr=-1, ednr=-1;
 
                     in >> hi >> index >> hi >> hi;
                     int codim = get<1>(element_map[index]);
@@ -712,7 +712,7 @@ namespace netgen
     if(!UserFormatRegister::HaveFormat(format))
       throw Exception("Unknown format: " + format);
 
-    const auto & entry = UserFormatRegister::Get(format);
+    const auto entry = UserFormatRegister::Get(format);
     if(!entry.read)
       throw Exception("Reading format " + format + " is not implemented");
 

libsrc/interface/rw_medit.cpp

@@ -53,8 +53,8 @@ void ReadMeditFormat (Mesh & mesh, const filesystem::path & filename, map<tuple<
       for([[maybe_unused]] auto k : Range(nvert)) {
         for(auto i : Range(dim))
           fin >> p[i];
-          fin >> index;
-          mesh.AddPoint(p);
+        fin >> index;
+        mesh.AddPoint(p);
       }
     }
     else if(token == "Edges") {
@@ -64,10 +64,10 @@ void ReadMeditFormat (Mesh & mesh, const filesystem::path & filename, map<tuple<
       for([[maybe_unused]] auto k : Range(nedge)) {
         for(auto i : Range(2))
           fin >> seg[i];
-          fin >> seg.edgenr;
-          seg.edgenr = getIndex(1, seg.edgenr);
-          seg.si = seg.edgenr;
-          mesh.AddSegment(seg);
+        fin >> seg.edgenr;
+        seg.edgenr = getIndex(1, seg.edgenr);
+        seg.si = seg.edgenr;
+        mesh.AddSegment(seg);
       }
     }
     else if(token == "Triangles") {
@@ -77,9 +77,9 @@ void ReadMeditFormat (Mesh & mesh, const filesystem::path & filename, map<tuple<
       for([[maybe_unused]] auto k : Range(ntrig)) {
         for(auto i : Range(3))
           fin >> sel[i];
-          fin >> index;
-          sel.SetIndex(getIndex(2, index));
-          mesh.AddSurfaceElement(sel);
+        fin >> index;
+        sel.SetIndex(getIndex(2, index));
+        mesh.AddSurfaceElement(sel);
       }
     }
     else if(token == "Tetrahedra") {
@@ -89,10 +89,10 @@ void ReadMeditFormat (Mesh & mesh, const filesystem::path & filename, map<tuple<
       for([[maybe_unused]] auto k : Range(ntet)) {
         for(auto i : Range(4))
           fin >> el[i];
-          fin >> index;
-          el.SetIndex(getIndex(3, index));
-          el.Invert();
-          mesh.AddVolumeElement(el);
+        fin >> index;
+        el.SetIndex(getIndex(3, index));
+        el.Invert();
+        mesh.AddVolumeElement(el);
       }
     }
     else if(token == "Corners") {

libsrc/interface/writeuser.cpp

@@ -39,7 +39,7 @@ bool WriteUserFormat (const string & format,
   if(!UserFormatRegister::HaveFormat(format))
     return true;
 
-  const auto & entry = UserFormatRegister::Get(format);
+  const auto entry = UserFormatRegister::Get(format);
   if(!entry.write)
     return true;
 

libsrc/linalg/densemat.cpp

@@ -49,7 +49,7 @@ namespace netgen
   {
     data = NULL; height = width = 0;
     SetSize (m2.Height(), m2.Width());
-    if (Height()*Width())
+    if (Height() && Width())
       memcpy (data, m2.data, sizeof(double) * (Height() * Width()));
   }
 
@@ -70,7 +70,7 @@ namespace netgen
 
     delete[] data;
 
-    if (h*w)  
+    if (h && w)  
       data = new double[h*w];
     else
       data = NULL;

libsrc/meshing/boundarylayer.cpp

@@ -788,9 +788,9 @@ namespace netgen
                 if(fabs(mat.Det()) > 1e-6)
                   break;
               }
-            int maxpos1;
-            int maxpos2;
-            double val = 0;
+            int maxpos1 = 0;
+            int maxpos2 = 1;
+            double val = ns[0] * ns[1];
             for (auto i : Range(ns))
               {
                 for (auto j : Range(i + 1, ns.Size()))

libsrc/meshing/improve3.cpp

@@ -1066,7 +1066,8 @@ double MeshOptimize3d :: SwapImproveEdge (
               bad3 += GetLegalPenalty();
         }
 
-      bool swap2, swap3;
+      bool swap2=false;
+      bool swap3=false;
 
       if (goal == OPT_CONFORM)
         {
@@ -2608,7 +2609,7 @@ double MeshOptimize3d :: SplitImprove2Element (
   // search for very flat tets, with two disjoint edges nearly crossing, like a rectangle with diagonals
   int minedge = -1;
   double mindist = 1e99;
-  double minlam0, minlam1;
+  double minlam0=0, minlam1=0;
 
   for (int i : Range(3))
   {