fix(install): avoid linking bootstrap temp clones

Author: kjw3

install.sh

@@ -53,7 +53,7 @@ exec_installer_from_ref() {
 
   if has_payload_marker "$payload_script"; then
     verify_downloaded_script "$payload_script" "versioned installer"
-    NEMOCLAW_INSTALL_REF="$ref" NEMOCLAW_INSTALL_TAG="$ref" NEMOCLAW_REPO_ROOT="$source_root" \
+    NEMOCLAW_INSTALL_REF="$ref" NEMOCLAW_INSTALL_TAG="$ref" NEMOCLAW_BOOTSTRAP_PAYLOAD=1 \
       bash "$payload_script" "$@"
     return
   fi

scripts/install.sh

@@ -833,6 +833,10 @@ is_source_checkout() {
   [[ -f "$package_json" ]] || return 1
   grep -q '"name"[[:space:]]*:[[:space:]]*"nemoclaw"' "$package_json" 2>/dev/null || return 1
 
+  if [[ "${NEMOCLAW_BOOTSTRAP_PAYLOAD:-}" == "1" ]]; then
+    return 1
+  fi
+
   if [[ -n "${NEMOCLAW_REPO_ROOT:-}" || -d "${repo_root}/.git" ]]; then
     return 0
   fi

test/install-preflight.test.js

@@ -1336,6 +1336,29 @@ describe("installer pure helpers", () => {
     expect(r.stdout.trim()).toBe("yes");
   });
 
+  it("is_source_checkout: rejects bootstrap payload clones even when git metadata exists", () => {
+    const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-source-checkout-bootstrap-"));
+    fs.mkdirSync(path.join(tmp, ".git"));
+    fs.writeFileSync(
+      path.join(tmp, "package.json"),
+      JSON.stringify({ name: "nemoclaw", version: "0.1.0" }, null, 2),
+    );
+    const r = spawnSync(
+      "bash",
+      [
+        "-c",
+        `source "${INSTALLER}" 2>/dev/null; is_source_checkout "${tmp}" && echo yes || echo no`,
+      ],
+      {
+        cwd: tmp,
+        encoding: "utf-8",
+        env: { HOME: tmp, PATH: TEST_SYSTEM_PATH, NEMOCLAW_BOOTSTRAP_PAYLOAD: "1" },
+      },
+    );
+    expect(r.status).toBe(0);
+    expect(r.stdout.trim()).toBe("no");
+  });
+
   it("resolve_installer_version: falls back to package.json when git tags are unavailable", () => {
     const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-resolve-ver-pkg-"));
     fs.mkdirSync(path.join(tmp, ".git"));
@@ -1822,7 +1845,8 @@ EOS
 #!/usr/bin/env bash
 set -euo pipefail
 # NEMOCLAW_VERSIONED_INSTALLER_PAYLOAD=1
-node "$NEMOCLAW_REPO_ROOT/bin/lib/usage-notice.js"
+repo_root="\${NEMOCLAW_REPO_ROOT:-$(cd "$(dirname "\${BASH_SOURCE[0]}")/.." && pwd)}"
+node "$repo_root/bin/lib/usage-notice.js"
 EOS
   chmod +x "$target/scripts/install.sh"
   exit 0