Skip to content

Commit 15c4c2b

Browse files
ajdeconsupertetelman
authored andcommitted
Fix linting errors in network operator role
1 parent bf99f7e commit 15c4c2b

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

roles/nvidia-network-operator/tasks/main.yaml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,20 @@
22
# Deploy network operator related tasks on master node
33
#
44

5-
- name: label the nodes
5+
- name: label the nodes # noqa command-instead-of-shell
66
shell: kubectl label --overwrite nodes {{ item }} node-role.kubernetes.io/worker=
7-
with_items: "{{ groups['kube-node']}}"
7+
with_items: "{{ groups['kube-node'] }}"
8+
changed_when: false
89

910
## required as the DeepOps openshift role doesn't work
10-
- name: Install openshift
11+
- name: Install openshift # noqa command-instead-of-shell
1112
shell: pip3 install openshift
13+
changed_when: false
1214

1315
- name: Add helm repo for network operator
1416
kubernetes.core.helm_repository:
1517
name: mellanox
16-
repo_url: "{{nvidia_network_operator_url}}"
18+
repo_url: "{{ nvidia_network_operator_url }}"
1719

1820
- name: Deploy network operator helm chart
1921
kubernetes.core.helm:
@@ -34,8 +36,8 @@
3436
include_tasks: sriovibnetwork.yaml
3537
with_items: "{{ intf_resources }}"
3638

37-
- name: Install latest Kubeflow MPI-Operator
39+
- name: Install latest Kubeflow MPI-Operator
3840
k8s:
3941
state: present
40-
definition: "{{ lookup('url', '{{mpi_raw_url}}/mpi-operator.yaml', split_lines=False) }}"
42+
definition: "{{ lookup('url', '{{ mpi_raw_url }}/mpi-operator.yaml', split_lines=False) }}"
4143
run_once: true

roles/nvidia-network-operator/tasks/sriovibnetwork.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
{
1212
"type": "whereabouts",
1313
"datastore": "kubernetes",
14-
"kubernetes": {
14+
"kubernetes": {
1515
"kubeconfig": "/etc/cni/net.d/whereabouts.d/whereabouts.kubeconfig"
1616
},
1717
"range": "{{ item.ip_addr }}",

roles/nvidia-network-operator/vars/main.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#
33
# variables for VFs, resource names,interface names and software versions.
44
# pf_name is the physical interface with sriov enabled
5-
# res_name must match container's network resources in job file
5+
# res_name must match container's network resources in job file
66
# if_name must match k8s network annotation name
77
#
88

0 commit comments

Comments
 (0)