Add per-component hostNetwork support for all DaemonSet operands#2246
Conversation
bf629bf to
f847562
Compare
|
@cdesiniotis @karthikvetrivel @tariq1890 PTAL, Thanks! |
|
/ok to test f847562 |
|
Thanks @calmkart. Given that driver daemonset can be run in host network namespace when provisioned using clusterpolicy, I would like to have the same change done for driver daemonset when its provisioned via nvidiadriver CR. So basically adding the changes here: gpu-operator/api/nvidia/v1alpha1/nvidiadriver_types.go Lines 40 to 206 in b0d0c16 https://github.com/NVIDIA/gpu-operator/blob/main/manifests/state-driver/0500_daemonset.yaml And then to nvidiadriver template: https://github.com/NVIDIA/gpu-operator/blob/main/deployments/gpu-operator/templates/nvidiadriver.yaml Also, this PR needs to be rebased from main as some of our CI checks have changed and would require the PR to be rebased so that they can be run. |
f847562 to
1d3c36b
Compare
@rahulait rebase done && update for driver done, PTAL |
|
/ok to test 1d3c36b |
|
It looks like bundle/manifests is missing updated CRD schema change for nvidiadriver? |
fixed |
|
/ok to test 1917379 |
|
@calmkart Can you squash your commit history ? |
1917379 to
d05d98c
Compare
Signed-off-by: Calm Peng <494296669@qq.com>
d05d98c to
092ddba
Compare
@tariq1890 ok, all done |
|
/ok to test 092ddba |
|
/cherry-pick release-26.3 |
|
🤖 Backport PR created for |
Summary
hostNetworksupport for all DaemonSet operands in ClusterPolicy CRDhostNetworkboolean field, following the existing DCGMExporter patternTest plan
applyHostNetworkConfighelper (nil/true/false cases)make generateandmake manifestsrun successfullyDescription
Previously, only DCGMExporter supported configuring hostNetwork through the ClusterPolicy CRD. This commit extends hostNetwork support to all remaining DaemonSet components: Driver, VGPUManager, Toolkit, DevicePlugin, SandboxDevicePlugin, KataDevicePlugin, DCGM, NodeStatusExporter, GPUFeatureDiscovery, MIGManager, KataManager, VFIOManager, CCManager, VGPUDeviceManager, and Validator.
Each component's Spec type now includes an optional HostNetwork *bool field following the same pattern as DCGMExporterSpec. When enabled, the controller sets hostNetwork: true and DNSPolicy: ClusterFirstWithHostNet on the corresponding DaemonSet pod spec.
Changes: