This repository was archived by the owner on May 20, 2026. It is now read-only.
MCC: fixed unhandled event listener errors#174
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes unhandled event listener errors in the Master Chief Collection game extension by adding proper error handling for file write operations. The change wraps file system operations that could previously throw unhandled exceptions in a try-catch block and provides user-friendly error notifications.
- Adds try-catch block around file write operations in the
applyToManifestfunction - Displays appropriate error notifications when file operations fail
- Increments version number to reflect the bug fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| game-masterchiefcollection/util.ts | Adds error handling around file write operations to prevent unhandled exceptions |
| game-masterchiefcollection/util.js | Compiled JavaScript version with the same error handling changes |
| game-masterchiefcollection/info.json | Version bump from 1.1.1 to 1.1.2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
insomnious
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Nexus-Mods/Vortex#18257