Skip to content
This repository was archived by the owner on May 20, 2026. It is now read-only.

MCC: fixed unhandled event listener errors#174

Merged
insomnious merged 1 commit into
masterfrom
18257-mcc-fixed-event-handlers
Sep 15, 2025
Merged

MCC: fixed unhandled event listener errors#174
insomnious merged 1 commit into
masterfrom
18257-mcc-fixed-event-handlers

Conversation

@IDCs
Copy link
Copy Markdown
Contributor

@IDCs IDCs commented Sep 11, 2025

@IDCs IDCs requested review from Copilot and insomnious September 11, 2025 08:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes unhandled event listener errors in the Master Chief Collection game extension by adding proper error handling for file write operations. The change wraps file system operations that could previously throw unhandled exceptions in a try-catch block and provides user-friendly error notifications.

  • Adds try-catch block around file write operations in the applyToManifest function
  • Displays appropriate error notifications when file operations fail
  • Increments version number to reflect the bug fix

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
game-masterchiefcollection/util.ts Adds error handling around file write operations to prevent unhandled exceptions
game-masterchiefcollection/util.js Compiled JavaScript version with the same error handling changes
game-masterchiefcollection/info.json Version bump from 1.1.1 to 1.1.2

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@insomnious insomnious merged commit 33fed8b into master Sep 15, 2025
@insomnious insomnious deleted the 18257-mcc-fixed-event-handlers branch September 15, 2025 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: canceled by user

3 participants