feat(spec): Add $self for identity-based referencing#451
Merged
Conversation
handrews
requested changes
Mar 23, 2026
handrews
left a comment
handrews
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this! Most of it looks great, a few minor bits plus RFC3986 base URI determination being a bit more complex than is stated here. Plus making it explicit that referencing an OAD by that OAD's $self requires examining potential target OADs for $self.
handrews
requested changes
Apr 11, 2026
handrews
left a comment
handrews
left a comment
Member
There was a problem hiding this comment.
Just a few more minor things... thanks for all of the work on this!
handrews
previously approved these changes
Apr 13, 2026
handrews
reviewed
Apr 13, 2026
handrews
approved these changes
Apr 15, 2026
handrews
left a comment
handrews
left a comment
Member
There was a problem hiding this comment.
@frankkilcommins it's interested that you softened that language with a "can" while @baywet made it a "MAY" over in Overlays. I have no idea which is better and am fine with either, I just thought I'd make a note of it.
ndenny
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #434