fixed author case

Author: Dishant1804

backend/apps/slack/management/commands/slack_sync_messages.py

@@ -323,64 +323,53 @@ def _create_message_from_data(
     ) -> Message | None:
         """Create Message instance using from_slack pattern."""
         try:
-            if not (slack_user_id := (message_data.get("user") or message_data.get("bot_id"))):
-                return None
+            slack_user_id = message_data.get("user") or message_data.get("bot_id")
+            author = None
 
-            try:
-                author = Member.objects.get(
-                    slack_user_id=slack_user_id, workspace=conversation.workspace
-                )
-            except Member.DoesNotExist:
-                author = None
-                retry_count = 0
-
-                while retry_count < max_retries:
-                    try:
-                        time.sleep(delay)
+            if slack_user_id:
+                try:
+                    author = Member.objects.get(
+                        slack_user_id=slack_user_id, workspace=conversation.workspace
+                    )
+                except Member.DoesNotExist:
+                    retry_count = 0
+                    while retry_count < max_retries:
+                        try:
+                            time.sleep(delay)
 
-                        user_info = client.users_info(user=slack_user_id)
-                        self._handle_slack_response(user_info, "users_info")
+                            user_info = client.users_info(user=slack_user_id)
+                            self._handle_slack_response(user_info, "users_info")
 
-                        author = Member.update_data(
-                            user_info["user"], conversation.workspace, save=True
-                        )
-                        self.stdout.write(
-                            self.style.SUCCESS(f"Created new member: {slack_user_id}")
-                        )
-                        break
-                    except SlackApiError as e:
-                        if e.response["error"] == "ratelimited":
-                            retry_after = int(
-                                e.response.headers.get("Retry-After", delay * (retry_count + 1))
+                            author = Member.update_data(
+                                user_info["user"], conversation.workspace, save=True
                             )
-
-                            retry_count += 1
-                            self.stdout.write(
-                                self.style.WARNING(
-                                    f"Rate limited on user info. Retrying after {retry_after}s"
-                                )
-                            )
-                            time.sleep(retry_after)
-                        else:
                             self.stdout.write(
-                                self.style.WARNING(
-                                    f"Failed to fetch user data for {slack_user_id}"
-                                )
+                                self.style.SUCCESS(f"Created new member: {slack_user_id}")
                             )
-                            return None
+                            break
 
-                if not author:
-                    self.stdout.write(
-                        self.style.WARNING(
-                            f"Could not fetch user {slack_user_id}, skipping message"
-                        )
-                    )
-                    return None
+                        except SlackApiError as e:
+                            if e.response.get("error") == "ratelimited":
+                                retry_after = int(e.response.headers.get("Retry-After", delay))
+                                retry_count += 1
+                                self.stdout.write(
+                                    self.style.WARNING(
+                                        f"Rate limited on user info Retrying after {retry_after}s"
+                                    )
+                                )
+                                time.sleep(retry_after)
+                            else:
+                                self.stdout.write(
+                                    self.style.ERROR(
+                                        f"Failed to fetch user data for {slack_user_id}: {e!s}"
+                                    )
+                                )
+                                break
 
             return Message.update_data(
                 data=message_data,
                 conversation=conversation,
-                author=author,
+                author=author if isinstance(author, Member) else None,
                 parent_message=parent_message,
                 save=False,
             )

backend/apps/slack/migrations/0016_message_is_bot_message_raw_data_alter_message_author.py

@@ -0,0 +1,34 @@
+# Generated by Django 5.2.3 on 2025-06-17 15:27
+
+import django.db.models.deletion
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("slack", "0015_remove_message_is_thread_parent_message_has_replies_and_more"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="message",
+            name="is_bot",
+            field=models.BooleanField(default=False, verbose_name="Is bot"),
+        ),
+        migrations.AddField(
+            model_name="message",
+            name="raw_data",
+            field=models.JSONField(default=dict, verbose_name="Raw data"),
+        ),
+        migrations.AlterField(
+            model_name="message",
+            name="author",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.CASCADE,
+                related_name="messages",
+                to="slack.member",
+            ),
+        ),
+    ]

backend/apps/slack/migrations/0016_message_raw_data.py

@@ -20,12 +20,15 @@ class Meta:
 
     created_at = models.DateTimeField(verbose_name="Created at")
     has_replies = models.BooleanField(verbose_name="Has replies", default=False)
+    is_bot = models.BooleanField(verbose_name="Is bot", default=False)
     raw_data = models.JSONField(verbose_name="Raw data", default=dict)
     slack_message_id = models.CharField(verbose_name="Slack message ID", max_length=50)
     text = models.TextField(verbose_name="Text")
 
     # FKs.
-    author = models.ForeignKey(Member, on_delete=models.CASCADE, related_name="messages")
+    author = models.ForeignKey(
+        Member, on_delete=models.CASCADE, related_name="messages", blank=True, null=True
+    )
     conversation = models.ForeignKey(
         Conversation, on_delete=models.CASCADE, related_name="messages"
     )
@@ -45,13 +48,14 @@ def from_slack(
         self,
         message_data: dict,
         conversation: Conversation,
-        author: Member,
+        author: "Member | None" = None,
         *,
         parent_message: "Message | None" = None,
     ) -> None:
         """Update instance based on Slack message data."""
         self.created_at = datetime.fromtimestamp(float(message_data["ts"]), tz=UTC)
         self.has_replies = message_data.get("reply_count", 0) > 0
+        self.is_bot = message_data.get("bot_id", "") != ""
         self.raw_data = message_data
         self.slack_message_id = message_data.get("ts", "")
         self.text = message_data.get("text", "")
@@ -69,7 +73,7 @@ def bulk_save(messages: list["Message"], fields=None) -> None:
     def update_data(
         data: dict,
         conversation: Conversation,
-        author: Member,
+        author: Member | None = None,
         *,
         parent_message: "Message | None" = None,
         save: bool = True,