Support different project directory during conversion

Author: millerds

packages/office-addin-project/.vscode/launch.json

@@ -14,7 +14,8 @@
         "-m",
         "${workspaceFolder}\\test\\TaskPane.manifest.xml",
         "-b",  
-        "${workspaceFolder}\\..\\temp.zip"
+        "${workspaceFolder}\\..\\temp.zip",
+        "--confirm"
       ]
     },
     {

packages/office-addin-project/src/cli.ts

@@ -29,6 +29,11 @@ commander
     "-b, --backup <backup-path>",
     "Specify the location of the backup folder for the project.  Default is './backup.zip'"
   )
+  .option(
+    "-p, --project <project-path>",
+    "Specify the location of the root directory of the project.  Default is the directory of the manifest file."
+  )
+  .option( "--confirm", "Confirmes the conversion")
   .action(commands.convert);
 
 if (process.argv.length > 2) {

packages/office-addin-project/src/commands.ts

@@ -11,10 +11,11 @@ export async function convert(command: commander.Command) {
   try {
     const manifestPath: string = command.manifest ?? "./manifest.xml";
     const backupPath: string = command.backup ?? "./backup.zip";
+    const projectPath: string = command.project ?? "";
+    const shouldContinue = command.confirm ?? await asksForUserConfirmation();
 
-    const shouldContinue = await asksForUserConfirmation();
     if (shouldContinue) {
-      await convertProject(manifestPath, backupPath);
+      await convertProject(manifestPath, backupPath, projectPath);
       usageDataObject.reportSuccess("convert", { result: "Project converted" });
     } else {
       usageDataObject.reportSuccess("convert", {

packages/office-addin-project/src/convert.ts

@@ -6,19 +6,26 @@ import * as fs from "fs";
 import * as fsExtra from "fs-extra";
 import * as path from "path";
 import * as util from "util";
-import { execSync } from "child_process";
+import { exec, execSync } from "child_process";
 import { convert } from "office-addin-manifest-converter";
 import { ExpectedError } from "office-addin-usage-data";
 
 /* global console */
 
+const execAsync = util.promisify(exec);
 const skipBackup: string[] = ["node_modules"];
 
 export async function convertProject(
   manifestPath: string = "./manifest.xml",
-  backupPath: string = "./backup.zip"
+  backupPath: string = "./backup.zip",
+  projectDir: string = ""
 ) {
   const outputPath: string = path.dirname(manifestPath);
+
+  // assume project dir is the same as manifest dir if not specified
+  projectDir = projectDir === "" ? outputPath : projectDir; 
+  process.chdir(projectDir);
+
   if (manifestPath.endsWith(".json")) {
     throw new ExpectedError(
       `The convert command only works on xml manifest based projects`
@@ -34,7 +41,7 @@ export async function convertProject(
   await backupProject(backupPath);
   try {
     await convert(manifestPath, outputPath, false /* imageDownload */, true /* imageUrls */);
-    updatePackages();
+    await updatePackages();
     await updateManifestXmlReferences();
     fs.unlinkSync(manifestPath);
   } catch (err: any) {
@@ -76,7 +83,7 @@ async function restoreBackup(backupPath: string) {
   zip.extractAllTo("./", true); // overwrite
 }
 
-function updatePackages(): void {
+async function updatePackages(): Promise<void> {
   // Contains name of the package and minimum version
   const depedentPackages: string[] = [
     "office-addin-debugging",
@@ -99,7 +106,7 @@ function updatePackages(): void {
 
   command += ` --save-dev`;
   console.log(messageToBePrinted.slice(0, -1));
-  execSync(command);
+  await execAsync(command);
 }
 
 async function updateManifestXmlReferences(): Promise<void> {