Refactor voxel grid label#4870
Draft
tin1254 wants to merge 89 commits into
Draft
Conversation
* Implement GridFilter for the common members * Implement TransformFilter for the abstracted filtering logic
* Showcase the bare bone structure of GridStruct * Test the functions of GridStruct required in applyFilter * Test different type of grid
* Move applyFilter to protected * Remove passing GridFilter pointer to GridStruct as can be done with static cast
* Remove confusing comment in applyFilter * Add line endings * Fix typo
* Declare new variables for testing instead of using variables from base class
* Move hashPoint, move checkIfOverflow and rename to checkHashRange
* TransformFilter holds GridStruct instead of inheriting it * Update unit tests
* Add in GridFilterBase and TransformFilter
* Remove the first multiplication as divb_mul_[0] is always 1 * Add test for 2D grid * Move outside as free functions * Use static_cast and floor in hashing and checking
* Fix class name in warning * Remove redundant casting in getGridStruct * Improve documentation of GridStruct in TransformFilter
* allow ADL Co-authored-by: Kunal Tyagi <tyagi.kunal@live.com>
* Pass TransformFilter point to constructor of GridStruct instead of setUp
* Rename function name to distinguish 2D and 3D
Member
|
Can we have a PR on your fork where we can see the differences between this and 4829? |
* Avoid give out pointer to unconstructed class
tin1254
force-pushed
the
refactor_voxel_grid_label
branch
from
c07ab3e to
27e729c
Compare
Contributor
Author
|
tin1254
force-pushed
the
refactor_voxel_grid_label
branch
from
27e729c to
a73e202
Compare
* Check with EXPECT_TRUE/FALSE instead of EXPECT_EQ/NE
* Template VoxelStruct with FilterBase
tin1254
force-pushed
the
refactor_voxel_grid_label
branch
2 times, most recently
from
5d04855 to
af5bc45
Compare
* Replace point check with existing marcos * Remove setUp check with different point types * Template equivalency check with point types
* Fix error on MSVC and Mac clang
tin1254
force-pushed
the
refactor_voxel_grid_label
branch
3 times, most recently
from
2caf75e to
a10655d
Compare
tin1254
force-pushed
the
refactor_voxel_grid_label
branch
2 times, most recently
from
4196cc9 to
a143329
Compare
tin1254
force-pushed
the
refactor_voxel_grid_label
branch
from
a143329 to
b9171f5
Compare
* Take leaf size instead of inverse leaf size * Fix documentation * Adapt unit tests
* Implement by inheriting from experimental VoxelGrid * Implement unit test for checking resulting label
* Fix std::map move assign seg fault * Inherit from LabeledVoxel
tin1254
force-pushed
the
refactor_voxel_grid_label
branch
from
b9171f5 to
195e6f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #4829
Description
Refactor
VoxelGridLabelsuch that it inherits fromVoxelGridGoal
Reduce the boilerplate code in other grid based filters