Fix 1908 - Version from API differs from manifest#1911
Open
o-l-a-v wants to merge 2 commits intoPowerShell:masterfrom
Open
Fix 1908 - Version from API differs from manifest#1911o-l-a-v wants to merge 2 commits intoPowerShell:masterfrom
o-l-a-v wants to merge 2 commits intoPowerShell:masterfrom
Conversation
o-l-a-v
requested review from
SydneyhSmith,
adityapatwardhan,
alerickson,
anamnavi and
shammu1
as code owners
Contributor
Author
|
Tests: Suggestions on how to test this without adding test against |
Member
|
thanks for the PR @o-l-a-v . The team needs to consider the design for the issue and decide. The design your solution suggests will be considered too, but I think we should leverage the existing version parsing and metadata file prioritization code that is already used for Local file share repositories and refactor that code out to a shared location (if not already done) for it to be used here. We would also need to consider preview versions (which are stored differently in .psd1 files versus .nuspec files), a package containing multiple .psd1 files, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Prefer version from the
.psd1manifest file if the version returned from the repository API is different. ElseImport-Modulefails, saying the manifest is not valid.I used Copilot to mock up needed changes. I implemented and tested them with modifications myself. Built the module and tested
Install-PSResource, like linked issue described.PR Context
#1908
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.