Apply suggestions from code review

rjmholt · bergmeister · web-flow · commit f2a518f96472 · 2019-03-05T19:47:15.000Z
Co-Authored-By: bergmeister &lt;c.bergmeister@gmail.com&gt;
diff --git a/Rules/UseConsistentIndentation.cs b/Rules/UseConsistentIndentation.cs
@@ -151,7 +151,7 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file
                         break;
 
                     case TokenKind.Pipe:
-                        var pipelineIsFollowedByNewlineOrLineContinuation = k < tokens.Length - 1 && k > 0 &&
+                        bool pipelineIsFollowedByNewlineOrLineContinuation = k < tokens.Length - 1 && k > 0 &&
                               (tokens[k + 1].Kind == TokenKind.NewLine || tokens[k + 1].Kind == TokenKind.LineContinuation);
                         if (!pipelineIsFollowedByNewlineOrLineContinuation)
                         {
@@ -163,7 +163,7 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file
                         }
                         else if (pipelineIndentationStyle == PipelineIndentationStyle.IncreaseIndentationForFirstPipeline)
                         {
-                            var isFirstPipeInPipeline = pipelineAsts.Any(pipelineAst => PositionIsEqual(((PipelineAst)pipelineAst).PipelineElements[0].Extent.EndScriptPosition, tokens[k - 1].Extent.EndScriptPosition));
+                            bool isFirstPipeInPipeline = pipelineAsts.Any(pipelineAst => PositionIsEqual(((PipelineAst)pipelineAst).PipelineElements[0].Extent.EndScriptPosition, tokens[k - 1].Extent.EndScriptPosition));
                             if (isFirstPipeInPipeline)
                             {
                                 AddViolation(token, indentationLevel++, diagnosticRecords, ref onNewLine);

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file`
`151`	`151`	`break;`
`152`	`152`
`153`	`153`	`case TokenKind.Pipe:`
`154`		`- var pipelineIsFollowedByNewlineOrLineContinuation = k < tokens.Length - 1 && k > 0 &&`
	`154`	`+ bool pipelineIsFollowedByNewlineOrLineContinuation = k < tokens.Length - 1 && k > 0 &&`
`155`	`155`	`(tokens[k + 1].Kind == TokenKind.NewLine \|\| tokens[k + 1].Kind == TokenKind.LineContinuation);`
`156`	`156`	`if (!pipelineIsFollowedByNewlineOrLineContinuation)`
`157`	`157`	`{`
`@@ -163,7 +163,7 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file`
`163`	`163`	`}`
`164`	`164`	`else if (pipelineIndentationStyle == PipelineIndentationStyle.IncreaseIndentationForFirstPipeline)`
`165`	`165`	`{`
`166`		`- var isFirstPipeInPipeline = pipelineAsts.Any(pipelineAst => PositionIsEqual(((PipelineAst)pipelineAst).PipelineElements[0].Extent.EndScriptPosition, tokens[k - 1].Extent.EndScriptPosition));`
	`166`	`+ bool isFirstPipeInPipeline = pipelineAsts.Any(pipelineAst => PositionIsEqual(((PipelineAst)pipelineAst).PipelineElements[0].Extent.EndScriptPosition, tokens[k - 1].Extent.EndScriptPosition));`
`167`	`167`	`if (isFirstPipeInPipeline)`
`168`	`168`	`{`
`169`	`169`	`AddViolation(token, indentationLevel++, diagnosticRecords, ref onNewLine);`