Skip to content

Commit da0d863

Browse files
committed
Fix arg handling for running as a script
1 parent 651612d commit da0d863

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

src/corppa/poetry_detection/compile_dataset.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,11 +271,14 @@ def run_ppa_metadata_step(
271271
)
272272

273273

274-
def main(*sysargs) -> None:
274+
def main(cmd_args=None) -> None:
275275
"""
276276
Main entry point for the dataset compilation script. Parses
277277
arguments to determine which steps to run.
278278
"""
279+
# allow passing arguments in; if not specified, draw from sys.argv/command line
280+
if cmd_args is None:
281+
cmd_args = sys.argv[1:]
279282
parser = argparse.ArgumentParser(description="Compile PPA found-poems dataset")
280283
parser.add_argument(
281284
"--compress-excerpts",
@@ -301,7 +304,7 @@ def main(*sysargs) -> None:
301304
action="append_const",
302305
const=step,
303306
)
304-
args = parser.parse_args(sysargs)
307+
args = parser.parse_args(cmd_args)
305308
# if not specified, run all steps
306309
compilation_steps = args.steps if args.steps else list(compilation_steps.keys())
307310

@@ -324,4 +327,4 @@ def main(*sysargs) -> None:
324327

325328

326329
if __name__ == "__main__":
327-
main(sys.argv)
330+
main()

tests/test_poetry_detection/test_compile_dataset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def test_main(
154154
"output_data_dir": tmp_path,
155155
}
156156

157-
main(*args)
157+
main(args)
158158

159159
if "merge" in expected_calls:
160160
mock_merge.assert_called_once()

0 commit comments

Comments
 (0)