Add support for space-separated HSL#55
Merged
Qix- merged 3 commits intoQix-:masterfrom Jul 17, 2021
htunnicliff:hsl-space-notation
Merged
Add support for space-separated HSL#55Qix- merged 3 commits intoQix-:masterfrom htunnicliff:hsl-space-notation
Qix- merged 3 commits intoQix-:masterfrom
htunnicliff:hsl-space-notation
Conversation
Owner
|
Man, bizarre. I wonder what the use-case was for them adding this. Anyway, thanks for the very complete PR :) |
Owner
|
Published as |
Contributor
Author
|
Thanks @Qix-! That was one of the fastest open-source PR merges I've ever seen 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for color strings that use space-separated HSL notation described in the CSS Colors Level 4 specification for the
hsl()function.This well-supported update to the
hsl()function supports values like these:Changes