fixing a single phrase not returning back multiple bigrams, #794#1362
Merged
tmylk merged 2 commits intoMay 23, 2017
Conversation
Contributor
|
Thanks. Let's remove the print and LGTM when tests pass |
Collaborator
|
Thanks! To ensure the same confusion as befell the 1st fix attempt doesn't occur – have you verified the updated test does fail, without the updated fix? |
Contributor
Author
|
@gojomo yes! Although I didn't commit the test first separately. A unit test was added in the previous PR, and it did pass. However, it wasn't verifying the behavior, as the expected bigram was already added by a previous sentence. My unit test isolates the actual behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's another try at fixing #794. The previous PR #879 added a unit test, but didn't catch the issue because the bigram "human interface" was already included from the very first entry. Added a more targetted unit test to catch this.