Skip to content

[MRG] Updated IPython notebook for scikit-learn wrappers#1428

Merged
menshikh-iv merged 9 commits into
piskvorky:developfrom
chinmayapancholi13:skl_ipynb_changes
Jun 21, 2017
Merged

[MRG] Updated IPython notebook for scikit-learn wrappers#1428
menshikh-iv merged 9 commits into
piskvorky:developfrom
chinmayapancholi13:skl_ipynb_changes

Conversation

@chinmayapancholi13
Copy link
Copy Markdown
Contributor

Updated scikit-learn IPython notebook to include examples for new models (RP Model and LdaSeq Model) and refactored the code for old models (LDA and LSI models).

@menshikh-iv
Copy link
Copy Markdown
Contributor

Please create short imports

from gensim.sklearn_integration.sklearn_wrapper_gensim_ldaseqmodel import SklLdaSeqModel

To avoid this, you can import all models in gensim/sklearn_integration/__init__.py (see example)

After this, you can replace your imports to

from gensim.sklearn_integration import SklLdaSeqModel

@tmylk
Copy link
Copy Markdown
Contributor

tmylk commented Jun 19, 2017

Please add cell output to the ipynb for completeness

@chinmayapancholi13
Copy link
Copy Markdown
Contributor Author

@menshikh-iv Thanks a lot! :) I have incorporated your suggestion in the __init__.py file and in the IPython notebook.

@chinmayapancholi13 chinmayapancholi13 changed the title [WIP] Updated scikit-learn IPython notebook [MRG] Updated IPython notebook for scikit-learn wrappers Jun 21, 2017
@menshikh-iv
Copy link
Copy Markdown
Contributor

Good work @chinmayapancholi13 👍

@menshikh-iv menshikh-iv merged commit b4da23c into piskvorky:develop Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants