Ensures FastText returns consistent dtypes#1638
Merged
Merged
Conversation
menshikh-iv
suggested changes
Oct 19, 2017
Contributor
menshikh-iv
left a comment
menshikh-iv
left a comment
There was a problem hiding this comment.
Nice!
Please add test for fasttext (check that now all types is consistent)
Contributor
Author
|
Cool! Will do. |
Contributor
|
Ping @mcobzarenco, how is going? |
mcobzarenco
force-pushed
the
fasttext-dtypes
branch
from
31ef726 to
a04db93
Compare
Contributor
Author
|
Sorry for the delay -- I now added a simple test to check that the dtypes are the same. |
mcobzarenco
force-pushed
the
fasttext-dtypes
branch
3 times, most recently
from
b648db7 to
c153f03
Compare
mcobzarenco
force-pushed
the
fasttext-dtypes
branch
from
c153f03 to
49cc940
Compare
Contributor
|
Thanks @mcobzarenco |
horpto
pushed a commit
to horpto/gensim
that referenced
this pull request
Oct 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1637