Add missing content to tarball#2194
Merged
Merged
Conversation
|
This patch doesn't apply on top of the release. |
Contributor
Author
|
@yurivict I know (fix added after the last release), this will be included in next release (not scheduled yet). |
This was referenced Oct 19, 2018
|
Apologies for commenting in a closed issue, but I was wondering if you're planning a 3.6.0 re-release or a minor subversion (even better?) which includes this patch. As of today, three months after this PR, the Thanks a lot. |
Contributor
Author
|
Hello @mino98, sorry for waiting, I hope we'll release Gensim 3.7.0 (or 3.6.1, depends on new features) in Dec/Jan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason why conda packages not builded - missing files in tarball, because conda use
tar.gzfrom PyPI, unlike gensim-wheels, where we use repository itself. Anyway, missing files in tarball is a bug (because user can't build all from sources).With adding new files, conda build & test package succesfully (see conda-forge/gensim-feedstock#14 for more info)