Skip to content

Cleanup (get rid py26 stuff)#2214

Merged
menshikh-iv merged 6 commits into
developfrom
cleanup
Oct 5, 2018
Merged

Cleanup (get rid py26 stuff)#2214
menshikh-iv merged 6 commits into
developfrom
cleanup

Conversation

@menshikh-iv
Copy link
Copy Markdown
Contributor

Just small cleanup

  • Remove ez_setup.py (no more relevant)
  • Fix loggers (use __name__ everywhere)
  • Add 3.7 to classifier
  • Use built-in bit_length

Copy link
Copy Markdown
Owner

@piskvorky piskvorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! Not sure about the CLI logging… do we want consistency (users see __main__), or do we want more descriptive log names (users see gensim.models.XYZ)?

Comment thread gensim/models/lda_dispatcher.py Outdated


logger = logging.getLogger("gensim.models.lda_dispatcher")
logger = logging.getLogger(__name__)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good idea in CLI scripts (__name__ will be just __main__ there).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: ee87342

@menshikh-iv menshikh-iv merged commit 2891861 into develop Oct 5, 2018
@menshikh-iv menshikh-iv deleted the cleanup branch October 5, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants