Skip to content

Optimize remove_unreachable_nodes in gensim.summarization#2263

Merged
menshikh-iv merged 3 commits into
piskvorky:developfrom
horpto:remove_unreachable_nodes-fix
Jan 8, 2019
Merged

Optimize remove_unreachable_nodes in gensim.summarization#2263
menshikh-iv merged 3 commits into
piskvorky:developfrom
horpto:remove_unreachable_nodes-fix

Conversation

@horpto
Copy link
Copy Markdown
Contributor

@horpto horpto commented Nov 9, 2018

No description provided.

Comment thread gensim/summarization/commons.py
@menshikh-iv
Copy link
Copy Markdown
Contributor

For merging this PR, @horpto please add tests for case suggested by @fedelopez77 (and merge fresh develop too).

@horpto horpto changed the title slightly optimize remove_unreachable_nodes [DNM] slightly optimize remove_unreachable_nodes Dec 13, 2018
@horpto horpto changed the title [DNM] slightly optimize remove_unreachable_nodes Slightly optimize remove_unreachable_nodes Dec 16, 2018
@horpto
Copy link
Copy Markdown
Contributor Author

horpto commented Dec 16, 2018

@menshikh-iv review, please

@menshikh-iv menshikh-iv changed the title Slightly optimize remove_unreachable_nodes Optimize remove_unreachable_nodes in gensim.summarization Jan 8, 2019
@menshikh-iv
Copy link
Copy Markdown
Contributor

Thanks @horpto 👍

@menshikh-iv menshikh-iv merged commit 02e8bf5 into piskvorky:develop Jan 8, 2019
@horpto horpto deleted the remove_unreachable_nodes-fix branch January 10, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants