Fix malletmodel2ldamodel conversion#2288
Merged
menshikh-iv merged 6 commits intoJan 8, 2019
Merged
Conversation
`malletmodel2ldamodel` sets up expElogbeta attribute but LdaModel.show_topics uses inner not dirichleted state instead. And moreover LdaState and LdaModel were not synced.
horpto
force-pushed
the
bug-2069-malletmodel2ldamodel
branch
from
4e957d1 to
532072d
Compare
menshikh-iv
changed the title
malletmodel2ldamodel conversion
Contributor
|
Great @horpto 👍 Please add example similar to #2069 (comment) as a test (to be fully sure) and run mallet-related tests on your machine. After that - I'll merge current PR |
|
Thank you horpto! Helped me a lot! |
Contributor
|
Awesome @horpto 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
malletmodel2ldamodelsets up expElogbeta attributebut LdaModel.show_topics uses inner not dirichleted state instead.
And moreover LdaState and LdaModel were not synced.
Fix #2069