Skip to content

Improve KeyedVector.wmdistance#2326

Merged
menshikh-iv merged 2 commits into
piskvorky:developfrom
horpto:wmdistance
Jan 11, 2019
Merged

Improve KeyedVector.wmdistance#2326
menshikh-iv merged 2 commits into
piskvorky:developfrom
horpto:wmdistance

Conversation

@horpto
Copy link
Copy Markdown
Contributor

@horpto horpto commented Jan 10, 2019

  • bring out check on docset1 from inner cycle
  • use symmetry of the metric to reduce calculations (actually in original code distance_matrix was not symmetrical sometimes although it should be by definition; pyemd forgives this)

@menshikh-iv menshikh-iv changed the title Improve wmdistance Improve KeyedVector.wmdistance Jan 10, 2019
@menshikh-iv
Copy link
Copy Markdown
Contributor

Thank you @horpto, you are top commiter in release ⭐

@menshikh-iv menshikh-iv merged commit 3a7760a into piskvorky:develop Jan 11, 2019
@horpto horpto deleted the wmdistance branch January 19, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants