Replace open() by smart_open() in gensim.models.fasttext._load_fasttext_format

[rsdel2007]

Fixed a TODO in fasttext.py.
Since https://github.com/RaRe-Technologies/smart_open/issues/207 is fixed now, we can replace open by smart_open.

[menshikh-iv]

@rsdel2007 thank you, please

• add a test (to avoid this regression in future)
• update smart-open version in setup.py (should be "first release that includes this bugfix)

[rsdel2007]

Okay I will do that.

[rsdel2007]

@menshikh-iv , there is already a test for the function _load_fasttext_format and after changes it passing the tests.

[menshikh-iv]

@rsdel2007 okay, just link it here and fix requirements

[rsdel2007]

Here is the link for the test of _load_fasttext_format.
What should I update smart_open, previously in setup.py it is written as smart_open >= 1.2.1.

[menshikh-iv]

@rsdel2007 update minimal version to version without a bug

[menshikh-iv]

this fixed in 1.7.0, is the problem still appears in 1.7.0?

[rsdel2007]

No, it is working fine for 1.7.0. Should I change it to 1.7.0?

[menshikh-iv]

of course, this must be minimal supported version

[rsdel2007]

Done. 👍

[menshikh-iv]

@rsdel2007 I temporary disabled CI here, will re-run later (next several days), I need all CIs for pre-release checks, sorry.

[menshikh-iv]

Thank you @rsdel2007 🥇