Skip to content

Update poincare documentation to indicate the relation format#2357

Merged
piskvorky merged 5 commits into
piskvorky:developfrom
AMR-KELEG:doc-poincare
Jan 28, 2019
Merged

Update poincare documentation to indicate the relation format#2357
piskvorky merged 5 commits into
piskvorky:developfrom
AMR-KELEG:doc-poincare

Conversation

@AMR-KELEG
Copy link
Copy Markdown
Contributor

Solves #2244

Comment thread gensim/models/poincare.py Outdated
Comment thread gensim/models/poincare.py Outdated
Comment thread gensim/models/poincare.py Outdated
@piskvorky
Copy link
Copy Markdown
Owner

Awesome! Thanks.

@piskvorky piskvorky merged commit c9c8b1f into piskvorky:develop Jan 28, 2019
@AMR-KELEG
Copy link
Copy Markdown
Contributor Author

@piskvorky I see that the issue is still not closed.
Should I have squashed the commits so that it's automatically closed?

@menshikh-iv
Copy link
Copy Markdown
Contributor

@AMR-KELEG close now, thanks for the contribution 👍

@menshikh-iv
Copy link
Copy Markdown
Contributor

menshikh-iv commented Jan 28, 2019

BTW next time, write fix #XYZ in the PR description instead, this automatically create an relation with issue and when PR merged - issue will close automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants