Skip to content

feat: support const and examples#10

Merged
RomanHotsiy merged 1 commit into
Redocly:masterfrom
csimi:support-const-and-examples
Jun 19, 2019
Merged

feat: support const and examples#10
RomanHotsiy merged 1 commit into
Redocly:masterfrom
csimi:support-const-and-examples

Conversation

@csimi
Copy link
Copy Markdown
Contributor

@csimi csimi commented Jun 5, 2019

const was added in JSON schema draft 6: https://json-schema.org/understanding-json-schema/reference/generic.html#constant-values
I see that "example" is supported on the OpenAPI level but it should also be supported in the JSON schema: https://json-schema.org/understanding-json-schema/reference/generic.html#annotations

@XVincentX
Copy link
Copy Markdown

@RomanHotsiy Any chance to get this merged?

@RomanHotsiy
Copy link
Copy Markdown
Member

Sorry, super busy. I will check this on weekends

@XVincentX
Copy link
Copy Markdown

Fantastic — this would really help us!

@XVincentX
Copy link
Copy Markdown

@RomanHotsiy Have you been able to check this out?

@RomanHotsiy RomanHotsiy merged commit 77b8fb2 into Redocly:master Jun 19, 2019
@RomanHotsiy
Copy link
Copy Markdown
Member

LGTM 👍 Thanks.
Will release a new version on weekends.

@RomanHotsiy
Copy link
Copy Markdown
Member

fyi: already released 1.0.0-beta.15

@XVincentX
Copy link
Copy Markdown

Oh fantastic, I'll try this out!

@XVincentX
Copy link
Copy Markdown

@RomanHotsiy I can't find it on npm 🤔

@RomanHotsiy
Copy link
Copy Markdown
Member

Whoops, looks like I have to update npm key on Travis. Deployed manually. Should be on npm already!

RomanHotsiy pushed a commit that referenced this pull request May 25, 2021
* feat: add more formats

* chore: pr feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants