FIX: parallel random value generation not being independent.

Author: phmbressan

.vscode/settings.json

@@ -136,6 +136,7 @@
         "meshgrid",
         "Metrum",
         "mult",
+        "multiprocess",
         "Mumma",
         "NASADEM",
         "NDAP",

docs/notebooks/monte_carlo_analysis/monte_carlo_analysis_outputs/monte_carlo_class_example.inputs.txt

@@ -230,7 +230,7 @@
     {
      "data": {
       "application/vnd.jupyter.widget-view+json": {
-       "model_id": "23586dd854c944e0b673ca4aa2cb5314",
+       "model_id": "d84184a4d6cd4b308effd022952bd8b0",
        "version_major": 2,
        "version_minor": 0
       },
@@ -507,7 +507,7 @@
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "[8927.944495610685, 6524.481738856048, 6559.534235033352, 6489.874776358132, 8171.666908273743]\n"
+      "[7093.420133006473, 7575.9811666258265, 6351.320054638862, 6123.550282734476, 5674.177733305354]\n"
      ]
     }
    ],
@@ -776,14 +776,14 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 15,
+   "execution_count": 21,
    "metadata": {},
    "outputs": [
     {
      "name": "stderr",
      "output_type": "stream",
      "text": [
-      "/home/phmb/github/RocketPy/rocketpy/simulation/monte_carlo.py:136: UserWarning: This class is still under testing and some attributes may be changed in next versions\n",
+      "/home/phmb/github/RocketPy/rocketpy/simulation/monte_carlo.py:132: UserWarning: This class is still under testing and some attributes may be changed in next versions\n",
       "  warnings.warn(\n"
      ]
     }
@@ -810,134 +810,21 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 16,
+   "execution_count": 22,
    "metadata": {},
    "outputs": [
     {
      "name": "stdout",
      "output_type": "stream",
      "text": [
-      "Starting Monte Carlo analysis\n",
-      "Number of simulations: 100sis\n",
-      "Current iteration: 000004 | Average Time per Iteration: 0.902 s | Estimated time left: 84 s\n",
-      "Current iteration: 000001 | Average Time per Iteration: 0.785 s | Estimated time left: 72 s\n",
-      "Current iteration: 000005 | Average Time per Iteration: 0.703 s | Estimated time left: 64 s\n",
-      "Current iteration: 000003 | Average Time per Iteration: 0.630 s | Estimated time left: 57 s\n",
-      "Current iteration: 000002 | Average Time per Iteration: 0.576 s | Estimated time left: 51 s\n",
-      "Current iteration: 000000 | Average Time per Iteration: 0.526 s | Estimated time left: 46 s\n",
-      "Current iteration: 000007 | Average Time per Iteration: 0.674 s | Estimated time left: 59 s\n",
-      "Current iteration: 000009 | Average Time per Iteration: 0.639 s | Estimated time left: 55 s\n",
-      "Current iteration: 000006 | Average Time per Iteration: 0.629 s | Estimated time left: 54 s\n",
-      "Current iteration: 000008 | Average Time per Iteration: 0.608 s | Estimated time left: 51 s\n",
-      "Current iteration: 000010 | Average Time per Iteration: 0.578 s | Estimated time left: 48 s\n",
-      "Current iteration: 000011 | Average Time per Iteration: 0.547 s | Estimated time left: 45 s\n",
-      "Current iteration: 000012 | Average Time per Iteration: 0.697 s | Estimated time left: 57 s\n",
-      "Current iteration: 000014 | Average Time per Iteration: 0.681 s | Estimated time left: 55 s\n",
-      "Current iteration: 000013 | Average Time per Iteration: 0.649 s | Estimated time left: 51 s\n",
-      "Current iteration: 000016 | Average Time per Iteration: 0.643 s | Estimated time left: 50 s\n",
-      "Current iteration: 000015 | Average Time per Iteration: 0.627 s | Estimated time left: 48 s\n",
-      "Current iteration: 000017 | Average Time per Iteration: 0.610 s | Estimated time left: 46 s\n",
-      "Current iteration: 000018 | Average Time per Iteration: 0.691 s | Estimated time left: 52 s\n",
-      "Current iteration: 000019 | Average Time per Iteration: 0.671 s | Estimated time left: 50 s\n",
-      "Current iteration: 000021 | Average Time per Iteration: 0.650 s | Estimated time left: 48 s\n",
-      "Current iteration: 000020 | Average Time per Iteration: 0.629 s | Estimated time left: 45 s\n",
-      "Current iteration: 000023 | Average Time per Iteration: 0.636 s | Estimated time left: 45 s\n",
-      "Current iteration: 000022 | Average Time per Iteration: 0.621 s | Estimated time left: 44 s\n",
-      "Current iteration: 000024 | Average Time per Iteration: 0.652 s | Estimated time left: 45 s\n",
-      "Current iteration: 000025 | Average Time per Iteration: 0.652 s | Estimated time left: 45 s\n",
-      "Current iteration: 000026 | Average Time per Iteration: 0.637 s | Estimated time left: 43 s\n",
-      "Current iteration: 000027 | Average Time per Iteration: 0.621 s | Estimated time left: 41 s\n",
-      "Current iteration: 000028 | Average Time per Iteration: 0.631 s | Estimated time left: 41 s\n",
-      "Current iteration: 000029 | Average Time per Iteration: 0.617 s | Estimated time left: 40 s\n",
-      "Current iteration: 000030 | Average Time per Iteration: 0.661 s | Estimated time left: 42 s\n",
-      "Current iteration: 000031 | Average Time per Iteration: 0.647 s | Estimated time left: 40 s\n",
-      "Current iteration: 000032 | Average Time per Iteration: 0.644 s | Estimated time left: 39 s\n",
-      "Current iteration: 000033 | Average Time per Iteration: 0.629 s | Estimated time left: 38 s\n",
-      "Current iteration: 000034 | Average Time per Iteration: 0.628 s | Estimated time left: 37 s\n",
-      "Current iteration: 000035 | Average Time per Iteration: 0.624 s | Estimated time left: 36 s\n",
-      "Current iteration: 000039 | Average Time per Iteration: 0.682 s | Estimated time left: 39 s\n",
-      "Current iteration: 000037 | Average Time per Iteration: 0.670 s | Estimated time left: 38 s\n",
-      "Current iteration: 000036 | Average Time per Iteration: 0.656 s | Estimated time left: 36 s\n",
-      "Current iteration: 000038 | Average Time per Iteration: 0.642 s | Estimated time left: 35 s\n",
-      "Current iteration: 000040 | Average Time per Iteration: 0.642 s | Estimated time left: 34 s\n",
-      "Current iteration: 000041 | Average Time per Iteration: 0.643 s | Estimated time left: 34 s\n",
-      "Current iteration: 000045 | Average Time per Iteration: 0.703 s | Estimated time left: 36 s\n",
-      "Current iteration: 000044 | Average Time per Iteration: 0.692 s | Estimated time left: 35 s\n",
-      "Current iteration: 000042 | Average Time per Iteration: 0.680 s | Estimated time left: 34 s\n",
-      "Current iteration: 000043 | Average Time per Iteration: 0.670 s | Estimated time left: 32 s\n",
-      "Current iteration: 000046 | Average Time per Iteration: 0.664 s | Estimated time left: 31 s\n",
-      "Current iteration: 000047 | Average Time per Iteration: 0.653 s | Estimated time left: 30 s\n",
-      "Current iteration: 000048 | Average Time per Iteration: 0.706 s | Estimated time left: 32 s\n",
-      "Current iteration: 000049 | Average Time per Iteration: 0.697 s | Estimated time left: 31 s\n",
-      "Current iteration: 000050 | Average Time per Iteration: 0.689 s | Estimated time left: 30 s\n",
-      "Current iteration: 000052 | Average Time per Iteration: 0.690 s | Estimated time left: 30 s\n",
-      "Current iteration: 000051 | Average Time per Iteration: 0.668 s | Estimated time left: 28 s\n",
-      "Current iteration: 000053 | Average Time per Iteration: 0.661 s | Estimated time left: 27 s\n",
-      "Current iteration: 000054 | Average Time per Iteration: 0.711 s | Estimated time left: 28 s\n",
-      "Current iteration: 000055 | Average Time per Iteration: 0.712 s | Estimated time left: 27 s\n",
-      "Current iteration: 000057 | Average Time per Iteration: 0.705 s | Estimated time left: 26 s\n",
-      "Current iteration: 000058 | Average Time per Iteration: 0.699 s | Estimated time left: 25 s\n",
-      "Current iteration: 000056 | Average Time per Iteration: 0.694 s | Estimated time left: 24 s\n",
-      "Current iteration: 000059 | Average Time per Iteration: 0.689 s | Estimated time left: 24 s\n",
-      "Current iteration: 000060 | Average Time per Iteration: 0.723 s | Estimated time left: 24 s\n",
-      "Current iteration: 000063 | Average Time per Iteration: 0.732 s | Estimated time left: 24 s\n",
-      "Current iteration: 000061 | Average Time per Iteration: 0.722 s | Estimated time left: 23 s\n",
-      "Current iteration: 000062 | Average Time per Iteration: 0.715 s | Estimated time left: 22 s\n",
-      "Current iteration: 000064 | Average Time per Iteration: 0.718 s | Estimated time left: 21 s\n",
-      "Current iteration: 000065 | Average Time per Iteration: 0.708 s | Estimated time left: 20 s\n",
-      "Current iteration: 000066 | Average Time per Iteration: 0.711 s | Estimated time left: 19 s\n",
-      "Current iteration: 000068 | Average Time per Iteration: 0.723 s | Estimated time left: 19 s\n",
-      "Current iteration: 000067 | Average Time per Iteration: 0.723 s | Estimated time left: 18 s\n",
-      "Current iteration: 000069 | Average Time per Iteration: 0.716 s | Estimated time left: 17 s\n",
-      "Current iteration: 000071 | Average Time per Iteration: 0.708 s | Estimated time left: 16 s\n",
-      "Current iteration: 000070 | Average Time per Iteration: 0.707 s | Estimated time left: 16 s\n",
-      "Current iteration: 000072 | Average Time per Iteration: 0.702 s | Estimated time left: 15 s\n",
-      "Current iteration: 000073 | Average Time per Iteration: 0.718 s | Estimated time left: 15 s\n",
-      "Current iteration: 000076 | Average Time per Iteration: 0.720 s | Estimated time left: 14 s\n",
-      "Current iteration: 000075 | Average Time per Iteration: 0.715 s | Estimated time left: 13 s\n",
-      "Current iteration: 000074 | Average Time per Iteration: 0.707 s | Estimated time left: 12 s\n",
-      "Current iteration: 000077 | Average Time per Iteration: 0.701 s | Estimated time left: 11 s\n",
-      "Current iteration: 000078 | Average Time per Iteration: 0.713 s | Estimated time left: 11 s\n",
-      "Current iteration: 000079 | Average Time per Iteration: 0.731 s | Estimated time left: 10 s\n",
-      "Current iteration: 000080 | Average Time per Iteration: 0.726 s | Estimated time left: 10 s\n",
-      "Current iteration: 000081 | Average Time per Iteration: 0.724 s | Estimated time left: 9 s \n",
-      "Current iteration: 000082 | Average Time per Iteration: 0.716 s | Estimated time left: 8 s \n",
-      "Current iteration: 000083 | Average Time per Iteration: 0.715 s | Estimated time left: 7 s \n",
-      "Current iteration: 000084 | Average Time per Iteration: 0.723 s | Estimated time left: 7 s \n",
-      "Current iteration: 000085 | Average Time per Iteration: 0.741 s | Estimated time left: 6 s \n",
-      "Current iteration: 000086 | Average Time per Iteration: 0.736 s | Estimated time left: 5 s \n",
-      "Current iteration: 000088 | Average Time per Iteration: 0.735 s | Estimated time left: 5 s \n",
-      "Current iteration: 000087 | Average Time per Iteration: 0.729 s | Estimated time left: 4 s \n",
-      "Current iteration: 000090 | Average Time per Iteration: 0.723 s | Estimated time left: 3 s \n",
-      "Current iteration: 000089 | Average Time per Iteration: 0.723 s | Estimated time left: 2 s \n",
-      "Current iteration: 000091 | Average Time per Iteration: 0.724 s | Estimated time left: 2 s \n",
-      "Current iteration: 000092 | Average Time per Iteration: 0.724 s | Estimated time left: 1 s \n",
-      "Current iteration: 000093 | Average Time per Iteration: 0.723 s | Estimated time left: 0 s \n",
-      "Current iteration: 000094 | Average Time per Iteration: 0.722 s | Estimated time left: 0 s \n",
-      "Worker stopped.\n",
-      "Current iteration: 000096 | Average Time per Iteration: 0.731 s | Estimated time left: 0 s \n",
-      "Worker stopped.\n",
-      "Current iteration: 000095 | Average Time per Iteration: 0.739 s | Estimated time left: 0 s \n",
-      "Worker stopped.\n",
-      "Current iteration: 000097 | Average Time per Iteration: 0.744 s | Estimated time left: 0 s \n",
-      "Worker stopped.\n",
-      "Current iteration: 000098 | Average Time per Iteration: 0.747 s | Estimated time left: 0 s \n",
-      "Worker stopped.\n",
-      "Current iteration: 000099 | Average Time per Iteration: 0.754 s | Estimated time left: 0 s \n",
-      "Worker stopped.\n",
-      "Joining writer workers.\n",
-      "--------------------------------------------------------------------------------\n",
-      "\n",
-      "All workers joined, simulation complete.\n",
-      "In total, 100 simulations were performed.\n",
-      "Simulation took 75.49 seconds to run.\n",
+      "Completed 10 iterations. Total wall time: 7.4 s                                           \n",
       "Results saved to /home/phmb/github/RocketPy/docs/notebooks/monte_carlo_analysis/monte_carlo_analysis_outputs/monte_carlo_class_example.outputs.txt\n"
      ]
     }
    ],
    "source": [
     "test_dispersion.simulate(\n",
-    "    number_of_simulations=100,\n",
+    "    number_of_simulations=10,\n",
     "    append=False,\n",
     "    parallel=True,\n",
     "    n_workers=None,\n",
@@ -971,79 +858,28 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 17,
+   "execution_count": null,
    "metadata": {},
-   "outputs": [
-    {
-     "name": "stdout",
-     "output_type": "stream",
-     "text": [
-      "A total of 100 simulations results were loaded from the following output file: monte_carlo_analysis_outputs/monte_carlo_class_example.outputs.txt\n",
-      "\n",
-      "The following input file was imported: monte_carlo_analysis_outputs/monte_carlo_class_example.inputs.txt\n",
-      "The following error file was imported: monte_carlo_analysis_outputs/monte_carlo_class_example.errors.txt\n"
-     ]
-    }
-   ],
+   "outputs": [],
    "source": [
     "# You only need to import results if you did not run the simulations\n",
     "test_dispersion.import_results()"
    ]
   },
   {
    "cell_type": "code",
-   "execution_count": 18,
+   "execution_count": null,
    "metadata": {},
-   "outputs": [
-    {
-     "data": {
-      "text/plain": [
-       "100"
-      ]
-     },
-     "execution_count": 18,
-     "metadata": {},
-     "output_type": "execute_result"
-    }
-   ],
+   "outputs": [],
    "source": [
     "test_dispersion.num_of_loaded_sims"
    ]
   },
   {
    "cell_type": "code",
-   "execution_count": 19,
+   "execution_count": null,
    "metadata": {},
-   "outputs": [
-    {
-     "name": "stdout",
-     "output_type": "stream",
-     "text": [
-      "Monte Carlo Simulation by RocketPy\n",
-      "Data Source:  monte_carlo_analysis_outputs/monte_carlo_class_example\n",
-      "Number of simulations:  100\n",
-      "Results: \n",
-      "\n",
-      "                Parameter            Mean       Std. Dev.\n",
-      "------------------------------------------------------------\n",
-      "     out_of_rail_velocity          26.043           2.053\n",
-      "     frontal_surface_wind           0.000           0.000\n",
-      "                 y_impact         410.468          61.706\n",
-      "          impact_velocity          -5.275           0.060\n",
-      "          max_mach_number           0.872           0.124\n",
-      "              apogee_time          25.665           1.856\n",
-      "                 apogee_y         351.443          55.161\n",
-      "     lateral_surface_wind           0.000           0.000\n",
-      "                   apogee        3442.128         587.869\n",
-      "                 apogee_x         472.614          84.688\n",
-      "         out_of_rail_time           0.356           0.023\n",
-      "out_of_rail_stability_margin           2.682           0.058\n",
-      " initial_stability_margin           2.621           0.058\n",
-      "                  t_final         309.069          30.988\n",
-      "                 x_impact         551.631          94.169\n"
-     ]
-    }
-   ],
+   "outputs": [],
    "source": [
     "test_dispersion.prints.all()"
    ]
@@ -1084,7 +920,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 22,
+   "execution_count": null,
    "metadata": {},
    "outputs": [],
    "source": [