Fix static analysis errors and add rector to build tools

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: loevgaard

.githooks/pre-commit

@@ -1,3 +1,4 @@
 #!/bin/sh
 
+composer rector
 composer fix-style

composer.json

@@ -94,6 +94,7 @@
         "analyse": "phpstan analyse",
         "check-style": "ecs check",
         "fix-style": "ecs check --fix",
-        "phpunit": "phpunit"
+        "phpunit": "phpunit",
+        "rector": "rector process"
     }
 }

tests/Functional/Calculator/AverageRatingCalculatorTest.php

@@ -8,7 +8,7 @@
 use Setono\SyliusReviewPlugin\Calculator\AverageRatingCalculator;
 use Sylius\Component\Core\Model\ProductInterface;
 use Sylius\Component\Core\Model\ProductReview;
-use Sylius\Component\Customer\Model\CustomerInterface;
+use Sylius\Component\Review\Model\ReviewerInterface;
 use Sylius\Component\Review\Model\ReviewInterface;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 
@@ -20,7 +20,7 @@ final class AverageRatingCalculatorTest extends KernelTestCase
 
     private ProductInterface $product;
 
-    private CustomerInterface $customer;
+    private ReviewerInterface $customer;
 
     protected function setUp(): void
     {
@@ -37,8 +37,8 @@ protected function setUp(): void
         self::assertNotNull($product, 'No fixture product found. Make sure Sylius fixtures are loaded.');
         $this->product = $product;
 
-        /** @var CustomerInterface|null $customer */
-        $customer = $this->entityManager->getRepository(CustomerInterface::class)->findOneBy([]);
+        /** @var ReviewerInterface|null $customer */
+        $customer = $this->entityManager->getRepository(ReviewerInterface::class)->findOneBy([]);
         self::assertNotNull($customer, 'No fixture customer found. Make sure Sylius fixtures are loaded.');
         $this->customer = $customer;
 

tests/Unit/Calculator/CachedAverageRatingCalculatorTest.php

@@ -74,7 +74,10 @@ public function it_caches_result_with_correct_key_format(): void
             }),
             Argument::type('callable'),
         )->will(function (array $args) use ($item) {
-            return $args[1]($item->reveal());
+            /** @var callable $callback */
+            $callback = $args[1];
+
+            return $callback($item->reveal());
         })->shouldBeCalledOnce();
 
         $calculator = new CachedAverageRatingCalculator($decorated->reveal(), $cache->reveal());
@@ -97,7 +100,10 @@ public function it_respects_custom_cache_lifetime(): void
         $cache = $this->prophesize(CacheInterface::class);
         $cache->get(Argument::type('string'), Argument::type('callable'))
             ->will(function (array $args) use ($item) {
-                return $args[1]($item->reveal());
+                /** @var callable $callback */
+                $callback = $args[1];
+
+                return $callback($item->reveal());
             })->shouldBeCalledOnce();
 
         $calculator = new CachedAverageRatingCalculator($decorated->reveal(), $cache->reveal(), 1800);