Skip to content

Upgrade golangci linter#416

Merged
miry merged 1 commit into
masterfrom
golanglint-update
Aug 28, 2022
Merged

Upgrade golangci linter#416
miry merged 1 commit into
masterfrom
golanglint-update

Conversation

@miry
Copy link
Copy Markdown
Contributor

@miry miry commented Aug 26, 2022 •
edited
Loading

Linter shows warning messages to update config:

$ golangci-lint run
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused. 
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.

Remove those plugins.

Resolve new golangci-linter checks:

  • One of the big change: Setup timeouts for HTTP servers.

UPDATE: Do not merge. Need to test issue base on previous versions.

@miry miry self-assigned this Aug 26, 2022
@miry miry added the Toxiproxy label Aug 26, 2022
@miry miry added this to the 2.5.0 milestone Aug 26, 2022
@miry miry mentioned this pull request Aug 26, 2022
Closed
18 tasks
@miry miry force-pushed the golanglint-update branch from 0de576e to 756ec2e Compare August 26, 2022 22:49
@miry miry changed the title Remove unmaintained golang-linter plugins Upgrade golangci linter Aug 26, 2022
@miry miry force-pushed the golanglint-update branch 4 times, most recently from 4fbc7fc to 9dd283d Compare August 26, 2022 23:38
@miry miry marked this pull request as ready for review August 26, 2022 23:40
@miry miry force-pushed the golanglint-update branch from 9dd283d to 1f69120 Compare August 27, 2022 00:03
@miry miry changed the title Upgrade golangci linter [WIP] Upgrade golangci linter Aug 27, 2022
@miry miry mentioned this pull request Aug 28, 2022
Closed
@miry miry changed the title [WIP] Upgrade golangci linter Upgrade golangci linter Aug 28, 2022
@miry miry force-pushed the golanglint-update branch 3 times, most recently from 57ed090 to f9a0fb7 Compare August 28, 2022 16:57
@miry
Upgrade golanglinter-ci
83ad834 
Remove unmaintained golang-linter plugins.
Fix linter warning messages.
@miry miry force-pushed the golanglint-update branch from f9a0fb7 to 83ad834 Compare August 28, 2022 17:23
@miry miry merged commit 83ad834 into master Aug 28, 2022
@miry miry deleted the golanglint-update branch August 28, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@miry miry

Labels

Toxiproxy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@miry