FIX: another Frank's bug: "A=p_Mult_q(A,A,...)" - never works!

Oleksandr Motsak · mohamed-barakat · commit f681a6066b0a · 2011-11-09T16:13:58.000+01:00
diff --git a/libpolys/polys/ext_fields/algext.cc b/libpolys/polys/ext_fields/algext.cc
@@ -387,7 +387,7 @@ void naPower(number a, int exp, number *b, const coeffs cf)
       expAbs = expAbs / 2;
       if (expAbs != 0)
       {
-        factor = p_Mult_q(factor, factor, naRing);
+        factor = p_Mult_q(factor, p_Copy(factor, naRing), naRing);
         heuristicReduce(factor, naMinpoly, cf);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,7 @@ void naPower(number a, int exp, number *b, const coeffs cf)`
`387`	`387`	`expAbs = expAbs / 2;`
`388`	`388`	`if (expAbs != 0)`
`389`	`389`	`{`
`390`		`- factor = p_Mult_q(factor, factor, naRing);`
	`390`	`+ factor = p_Mult_q(factor, p_Copy(factor, naRing), naRing);`
`391`	`391`	`heuristicReduce(factor, naMinpoly, cf);`
`392`	`392`	`}`
`393`	`393`	`}`