Skip to content

Entity Potion Effect Event#6532

Merged
sovdeeth merged 21 commits into
SkriptLang:dev/featurefrom
Asleeepp:addition-entity-potion-effect-event
Sep 22, 2024
Merged

Entity Potion Effect Event#6532
sovdeeth merged 21 commits into
SkriptLang:dev/featurefrom
Asleeepp:addition-entity-potion-effect-event

Conversation

@Asleeepp
Copy link
Copy Markdown
Contributor

@Asleeepp Asleeepp commented Apr 3, 2024

Description

Adds the Entity Potion Effect event, inspired by SkBee's syntax of the same event.
Adds the %past event-potioneffect%, %event-potioneffect% and %event-potioneffecttype% event-values for this event.

Original Issue: #5774

Note: I have no clue why some of the imports went to .*, sorry about that.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@AyhamAl-Ali AyhamAl-Ali added the feature Pull request adding a new feature. label Apr 4, 2024
Copy link
Copy Markdown
Member

@AyhamAl-Ali AyhamAl-Ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR ⚡

Comment thread src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java Outdated
Comment thread src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java Outdated
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
Comment thread src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
@Asleeepp Asleeepp requested a review from sovdeeth April 19, 2024 02:30
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
@sovdeeth sovdeeth changed the base branch from master to dev/feature April 19, 2024 22:49
@sovdeeth
Copy link
Copy Markdown
Member

Build failures due to upstream paper change, will be fixed when patch is merged into feature

@Asleeepp
Copy link
Copy Markdown
Contributor Author

Asleeepp commented Apr 19, 2024

Build failures due to upstream paper change, will be fixed when patch is merged into feature

oh okay, was losing my mind wondering what was wrong lmao

Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
Comment thread src/main/resources/lang/default.lang Outdated
Comment thread src/main/resources/lang/default.lang
@Asleeepp Asleeepp requested a review from sovdeeth April 20, 2024 18:17
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems alright to me off the top of my head

Comment thread src/main/resources/lang/default.lang Outdated
@Asleeepp Asleeepp requested a review from AyhamAl-Ali April 20, 2024 20:21
@sovdeeth sovdeeth added the 2.9 label Jun 29, 2024
Comment thread src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java Outdated
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
Comment thread src/main/java/ch/njol/skript/events/EvtEntityPotion.java Outdated
@Asleeepp Asleeepp requested a review from UnderscoreTud July 1, 2024 22:48
@APickledWalrus APickledWalrus removed the 2.9 label Jul 2, 2024
Comment thread src/main/java/ch/njol/skript/classes/data/BukkitClasses.java Outdated
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Aug 17, 2024
@sovdeeth sovdeeth merged commit c4c5560 into SkriptLang:dev/feature Sep 22, 2024
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Entity Potion Effect Event and event-values

* Updated syntax for EvtEntityPotion, and readded the imports to EventValues.

* Forgot to change e to event.

* Added suggested changes :)

* silly me

* even sillier me (how did I manage to do that)

* even sillier me (how did I manage to do that)

* I don't get why the build is failing

* BRO

* Added type stuff, and made check a lot better

* Changes

* change

* done

* resolve conflict

* Update src/main/java/ch/njol/skript/classes/data/BukkitClasses.java

Co-authored-by: _tud <98935832+UnderscoreTud@users.noreply.github.com>

---------

Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
Co-authored-by: _tud <98935832+UnderscoreTud@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants