Skip to content

Deprecate outdated utils/validate#6666

Merged
Moderocky merged 4 commits into
SkriptLang:feature/deprecate-outdated-utilsfrom
kiip1:deprecate-outdated-utils/validate
May 8, 2024
Merged

Deprecate outdated utils/validate#6666
Moderocky merged 4 commits into
SkriptLang:feature/deprecate-outdated-utilsfrom
kiip1:deprecate-outdated-utils/validate

Conversation

@kiip1
Copy link
Copy Markdown
Contributor

@kiip1 kiip1 commented May 8, 2024

Technically does change some behaviour (no longer checks for null parameters in some cases) but as these are marked with the NotNull annotation developers should not expect it to work when null gets passed anyways.

I did keep the validation in CommandAliasHelpTopic since it actually checks something that isn't covered by annotations

@Moderocky
Copy link
Copy Markdown
Member

Isn't there some google validate nonsense inside Bukkit we could use instead. Preconditions, maybe?

@Moderocky Moderocky added the housekeeping Housekeeping-related issue or task. label May 8, 2024
@kiip1
Copy link
Copy Markdown
Contributor Author

kiip1 commented May 8, 2024

Switched those usages to preconditions

@Moderocky Moderocky merged commit 1446e31 into SkriptLang:feature/deprecate-outdated-utils May 8, 2024
@kiip1 kiip1 deleted the deprecate-outdated-utils/validate branch May 8, 2024 13:06
Moderocky pushed a commit that referenced this pull request May 30, 2024
* Mark Validate as internal

* Schedule for removal + change usages

* Use preconditions
Moderocky added a commit that referenced this pull request Jan 1, 2025
* Mark Validate as internal

* Schedule for removal + change usages

* Use preconditions
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Mark Validate as internal

* Schedule for removal + change usages

* Use preconditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Housekeeping-related issue or task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants