Skip to content

Warden+#7314

Merged
erenkarakal merged 16 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/WardenPlus
Mar 31, 2025
Merged

Warden+#7314
erenkarakal merged 16 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/WardenPlus

Conversation

@Absolutionism
Copy link
Copy Markdown
Contributor

@Absolutionism Absolutionism commented Dec 27, 2024

Description

This PR aims to add additional control over Wardens. Allowing users to set a wardens anger level towards an entity and make them sense a disturbance.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 27, 2024
Copy link
Copy Markdown
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things

Comment thread src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprWardenAngryAt.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprWardenEntityAnger.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java Outdated
Co-authored-by: Shane Bee <shanebolenback@me.com>
Copy link
Copy Markdown
Contributor

@ShaneBeee ShaneBeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my approval... for sport!

Copy link
Copy Markdown
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking real good.

Comment thread src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprWardenAngryAt.java Outdated
Comment thread src/test/skript/tests/syntaxes/expressions/ExprWardenEntityAnger.sk
Comment thread src/main/java/ch/njol/skript/expressions/ExprWardenAngryAt.java Outdated
Comment thread src/main/java/ch/njol/skript/expressions/ExprWardenEntityAnger.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java Outdated
@Efnilite Efnilite added feature Pull request adding a new feature. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Dec 31, 2024
Comment thread src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java Outdated
@Absolutionism Absolutionism requested a review from a team as a code owner March 19, 2025 22:29
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 19, 2025
@sovdeeth sovdeeth removed the request for review from a team March 21, 2025 01:49
@erenkarakal erenkarakal merged commit bf0000f into SkriptLang:dev/feature Mar 31, 2025
erenkarakal added a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* Docs Update

* Update src/main/java/ch/njol/skript/effects/EffWardenDisturbance.java

Co-authored-by: Shane Bee <shanebolenback@me.com>

* Requested Changes

* Requested Changes

* Fix Test

* Desc

---------

Co-authored-by: SirSmurfy2 <82696841+TheAbsolutionism@users.noreply.github.com>
Co-authored-by: Shane Bee <shanebolenback@me.com>
Co-authored-by: Eren <67760502+erenkarakal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants