Allow addons to use the %classinfo% value property expression.#7359
Merged
Conversation
Moderocky
requested review from
APickledWalrus,
Efnilite,
UnderscoreTud and
sovdeeth
Efnilite
approved these changes
Jan 7, 2025
| }) | ||
| @Since("2.10") | ||
| public class ExprNodeValue extends SimplePropertyExpression<Node, Object> { | ||
| @Since("2.10 (Nodes), INSERT VERSION (Any)") |
Member
There was a problem hiding this comment.
Suggested change
| @Since("2.10 (Nodes), INSERT VERSION (Any)") | |
| @Since("2.10 (nodes), INSERT VERSION (any)") |
| } | ||
|
|
||
| /** | ||
| * |
Comment on lines
+23
to
+24
| @UnknownNullability | ||
| Type value(); |
Member
There was a problem hiding this comment.
Suggested change
| @UnknownNullability | |
| Type value(); | |
| @UnknownNullability Type value(); |
UnderscoreTud
approved these changes
Jan 15, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
…iptLang#7359) * Add support for more value types. * Use proper array types. * Remove old node value class. * Clean up some bad imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
2.10 added an experimental
%*classinfo% valueproperty for config nodes.I realised this is probably useful for things other than config nodes, particularly for addons that support stuff like data tags.
This adds an
AnyValuedtype that things can extend (or register converters for!) that allows the%*classinfo% valueproperty to be used in more places.