Skip to content

Make Player Sprint + Camel Is Dashing#7365

Merged
sovdeeth merged 10 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/CamelSupport
Mar 19, 2025
Merged

Make Player Sprint + Camel Is Dashing#7365
sovdeeth merged 10 commits into
SkriptLang:dev/featurefrom
Absolutionism:dev/CamelSupport

Conversation

@Absolutionism
Copy link
Copy Markdown
Contributor

@Absolutionism Absolutionism commented Jan 2, 2025

Description

This PR allows users to make players sprint and check if a camel is dashing.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth
Copy link
Copy Markdown
Member

sovdeeth commented Jan 2, 2025

I don't think it's appropriate to merge these. Dashing is very different from sprinting, it's more like a jump or a lunge, not a toggled state.

Further conversation revealed this to be a confusion in how the bukkit method is named and how the camel's jump ability is named. The dashing methods do in fact refer to a sprinting state the camel can be in, not its dash ability.

Comment thread src/main/java/ch/njol/skript/conditions/CondIsDashing.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondIsDashing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffDashing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffSprinting.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffSprinting.java Outdated
@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 3, 2025
Copy link
Copy Markdown
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after these and @cheeezburga's changes

Comment thread src/test/skript/tests/syntaxes/effects/EffDashing.sk Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffDashing.java Outdated
Comment thread src/main/java/ch/njol/skript/conditions/CondIsDashing.java Outdated
@sovdeeth
Copy link
Copy Markdown
Member

sovdeeth commented Jan 3, 2025

re: the existing reviews
isn't this pr intended to be reverted to the initial commit?

@Absolutionism Absolutionism changed the title Camel Sprinting Make Player Sprint + Camel Is Dashing Jan 4, 2025
Comment thread src/main/java/ch/njol/skript/effects/EffSprinting.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffSprinting.java
Comment thread src/main/java/ch/njol/skript/conditions/CondIsDashing.java Outdated
Comment thread src/main/java/ch/njol/skript/effects/EffSprinting.java
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Feb 12, 2025
Copy link
Copy Markdown
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sovdeeth sovdeeth merged commit 24cc118 into SkriptLang:dev/feature Mar 19, 2025
erenkarakal pushed a commit to erenkarakal/Skript that referenced this pull request Nov 26, 2025
* Initial Commit

* Seperation

* Remove EffDashing

* Sprinting Docs Update

* Requested Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants