Skip to content

Fix non-empty event values in JSONGenerator #7656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sovdeeth merged 5 commits into from
Apr 9, 2025
Merged

Fix non-empty event values in JSONGenerator #7656

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29af50c
init commit
Efnilite Mar 1, 2025
9cf49a8
Merge branch 'dev/patch' into patch/fix-nonempty-event-values
Efnilite Mar 1, 2025
84bdb3a
update version
Efnilite Mar 6, 2025
f4644f4
Merge remote-tracking branch 'origin/patch/fix-nonempty-event-values'…
Efnilite Mar 6, 2025
91a3fef
Merge branch 'dev/feature' into patch/fix-nonempty-event-values
sovdeeth Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/ch/njol/skript/doc/JSONGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class JSONGenerator extends DocumentationGenerator {
/**
* The current version of the JSON generator
*/
public static final Version JSON_VERSION = new Version(1, 0);
public static final Version JSON_VERSION = new Version(1, 1);

private static final Gson GSON = new GsonBuilder()
.disableHtmlEscaping()
Expand Down Expand Up @@ -200,6 +200,10 @@ private static JsonArray getEventValues(SkriptEventInfo<?> info) {
}
}

if (eventValues.isEmpty()) {
return null;
}

JsonArray array = new JsonArray();
for (JsonObject eventValue : eventValues) {
array.add(eventValue);
Expand Down