Add "with all itemflags" to ExprWithItemFlags#7704
Merged
sovdeeth merged 9 commits intoMar 21, 2025
Conversation
sovdeeth
requested changes
Mar 16, 2025
Member
sovdeeth
left a comment
sovdeeth
left a comment
There was a problem hiding this comment.
maintain parity with patterns
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
requested changes
Mar 16, 2025
Member
sovdeeth
left a comment
sovdeeth
left a comment
There was a problem hiding this comment.
tests failing due to list comparison being in differing order
sovdeeth
added
the
enhancement
sovdeeth
approved these changes
Mar 16, 2025
Efnilite
requested changes
Mar 16, 2025
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Efnilite
approved these changes
Mar 16, 2025
Efnilite
added
the
feature-ready
sovdeeth
requested review from
Romitou and
UnderscoreTud
and removed request for
a team
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* ExprWithItemFlags - Add all itemflags support * ExprItemFlags.sk - change comment * Maintain parity with patterns Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com> * ExprItemFlags.sk - change comparison to check for any * ExprItemFlags.sk - remove comment * Update src/main/java/ch/njol/skript/expressions/ExprWithItemFlags.java Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add support for
%itemtype% with all item flags, while initial issue was "bug", it appeared the general consensus was to add with all item flags.Target Minecraft Versions: any
Requirements: none
Related Issues: #7604