Use NamespacedKeys instead of Material ordinals for ItemData serialization#7790
Merged
sovdeeth merged 2 commits intoApr 12, 2025
Merged
Conversation
sovdeeth
added
the
bug
sovdeeth
requested review from
APickledWalrus and
Romitou
and removed request for
a team
Efnilite
approved these changes
Apr 9, 2025
APickledWalrus
approved these changes
Apr 11, 2025
Efnilite
added
the
feature-ready
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
…ation (SkriptLang#7790) * Use namespacedkeys instead of ordinals for serialization * Update ItemData.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Material ordinals change between versions and cannot be relied upon for serialization.
This uses getKey to serialize and matchMaterial to deserialize.
We should recommend users upgrade to 2.11 without changing their minecraft version and run the server at least once before changing versions.
Target Minecraft Versions: any
Requirements: none
Related Issues: #7789