Skip to content

CI: Manifest workflows + daily schedule + optional S3 upload#2909

Draft
sfc-gh-kkomail wants to merge 13 commits intoSnowflake-Labs:masterfrom
sfc-gh-kkomail:Manifest
Draft

CI: Manifest workflows + daily schedule + optional S3 upload#2909
sfc-gh-kkomail wants to merge 13 commits intoSnowflake-Labs:masterfrom
sfc-gh-kkomail:Manifest

Conversation

@sfc-gh-kkomail
Copy link
Contributor

Adds manifest artifact/publish workflows, daily 11:59 PM PT schedule, and optional S3 upload (env-driven). No guide content format changes; manifest JSON structure is unchanged.

Copy link

@kameshsampath kameshsampath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Lets avoid using repo secrets and use Web Identity. An example workflow https://gist.github.com/kameshsampath/afdf41f517f6ceb190db6fc87c71a423

  • I think you can keep the manifest_generator.py just to generate the manifest JSON and aws cli should be in path already to do the upload so use aws s3 ...

  • We can merge manifest-artifact.yml and manifest-publish-branch.yml as two jobs within same workflow ? Since the upload depends on the mainfest generation, its better it to run after the generate than in parallel

  • Nice to see adding you are adding that artifact as build run asset. Its very helpful

  • Are we still committing to the repo or sticking just to upload to s3?

Copy link

@kameshsampath kameshsampath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need two jobs.github/workflows/manifest-artifact.yml and .github/workflows/manifest-publish-branch.yml ? guess one of them is stale ? Also lets rename the manifest-publish-branch.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants