Skip to content

Commit 19ed06d

Browse files
authored
Merge pull request #593 from Team-WSS/bugfix/592
bugfix: 컴포즈 뷰 다크모드 상단바 디자인 수정
2 parents c568ab5 + a3f3500 commit 19ed06d

7 files changed

Lines changed: 34 additions & 23 deletions

File tree

app/src/main/java/com/into/websoso/core/common/util/ExtentionFuction.kt

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.into.websoso.core.common.util
22

3+
import android.app.Activity
34
import android.content.Context
45
import android.content.Intent
56
import android.content.res.Resources
@@ -14,6 +15,8 @@ import androidx.compose.foundation.interaction.MutableInteractionSource
1415
import androidx.compose.runtime.Composable
1516
import androidx.compose.runtime.remember
1617
import androidx.compose.ui.Modifier
18+
import androidx.compose.ui.graphics.toArgb
19+
import androidx.core.view.WindowCompat
1720
import androidx.datastore.core.DataStore
1821
import androidx.datastore.core.handlers.ReplaceFileCorruptionHandler
1922
import androidx.datastore.preferences.SharedPreferencesMigration
@@ -28,6 +31,7 @@ import androidx.lifecycle.repeatOnLifecycle
2831
import com.into.websoso.BuildConfig
2932
import com.into.websoso.core.common.ui.custom.WebsosoCustomSnackBar
3033
import com.into.websoso.core.common.ui.custom.WebsosoCustomToast
34+
import com.into.websoso.core.designsystem.theme.White
3135
import kotlinx.coroutines.flow.Flow
3236
import kotlinx.coroutines.launch
3337
import java.io.Serializable
@@ -158,3 +162,11 @@ fun <T> Flow<T>.collectWithLifecycle(
158162
}
159163
}
160164
}
165+
166+
fun Activity.setupWhiteStatusBar() {
167+
this.window.statusBarColor = White.toArgb()
168+
169+
WindowCompat.getInsetsController(this.window, this.window.decorView).apply {
170+
isAppearanceLightStatusBars = true
171+
}
172+
}

app/src/main/java/com/into/websoso/core/designsystem/theme/Theme.kt

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,34 +16,13 @@ import androidx.compose.ui.platform.LocalContext
1616
private val DarkColorScheme = darkColorScheme(
1717
primary = Primary100,
1818
onPrimary = White,
19-
primaryContainer = Primary200,
20-
onPrimaryContainer = Gray20,
21-
secondary = Secondary100,
22-
onSecondary = White,
23-
onSecondaryContainer = Gray50,
24-
tertiary = Gray300,
2519
onTertiary = White,
26-
background = Black,
27-
onBackground = Gray20,
28-
onSurface = Gray200,
29-
onError = White,
3020
)
3121

3222
private val LightColorScheme = lightColorScheme(
3323
primary = Primary100,
3424
onPrimary = White,
35-
primaryContainer = Primary50,
36-
onPrimaryContainer = Gray20,
37-
secondary = Secondary100,
38-
onSecondary = White,
39-
onSecondaryContainer = Gray50,
40-
tertiary = Gray300,
4125
onTertiary = Black,
42-
background = White,
43-
onBackground = Gray300,
44-
surface = Gray20,
45-
onSurface = Gray70,
46-
onError = White,
4726
)
4827

4928
private val LocalWebsosoTypography = staticCompositionLocalOf<WebsosoTypography> {

app/src/main/java/com/into/websoso/ui/notification/NotificationActivity.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import androidx.activity.ComponentActivity
77
import androidx.activity.compose.setContent
88
import androidx.activity.viewModels
99
import com.into.websoso.core.common.ui.model.ResultFrom
10+
import com.into.websoso.core.common.util.setupWhiteStatusBar
1011
import com.into.websoso.core.designsystem.theme.WebsosoTheme
1112
import com.into.websoso.ui.feedDetail.FeedDetailActivity
1213
import com.into.websoso.ui.notification.model.NotificationModel
@@ -19,6 +20,7 @@ class NotificationActivity : ComponentActivity() {
1920

2021
override fun onCreate(savedInstanceState: Bundle?) {
2122
super.onCreate(savedInstanceState)
23+
this.setupWhiteStatusBar()
2224

2325
setContent {
2426
WebsosoTheme {

app/src/main/java/com/into/websoso/ui/notification/NotificationScreen.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package com.into.websoso.ui.notification
22

33
import androidx.activity.compose.BackHandler
4+
import androidx.compose.foundation.background
45
import androidx.compose.foundation.layout.Column
56
import androidx.compose.foundation.layout.fillMaxSize
67
import androidx.compose.runtime.Composable
78
import androidx.compose.runtime.getValue
89
import androidx.compose.ui.Modifier
910
import androidx.lifecycle.compose.collectAsStateWithLifecycle
11+
import com.into.websoso.core.designsystem.theme.White
1012
import com.into.websoso.ui.notification.component.NotificationAppBar
1113
import com.into.websoso.ui.notification.component.NotificationsContainer
1214
import com.into.websoso.ui.notification.model.NotificationModel
@@ -24,7 +26,11 @@ fun NotificationScreen(
2426
onBackButtonClick()
2527
}
2628

27-
Column(modifier = Modifier.fillMaxSize()) {
29+
Column(
30+
modifier = Modifier
31+
.fillMaxSize()
32+
.background(White),
33+
) {
2834
NotificationAppBar(onBackButtonClick)
2935
NotificationsContainer(
3036
notifications = uiState.notifications,

app/src/main/java/com/into/websoso/ui/notification/component/NotificationAppBar.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.into.websoso.ui.notification.component
22

33
import androidx.compose.foundation.Image
4+
import androidx.compose.foundation.background
45
import androidx.compose.foundation.layout.Row
56
import androidx.compose.foundation.layout.fillMaxWidth
67
import androidx.compose.foundation.layout.height
@@ -20,6 +21,7 @@ import com.into.websoso.R
2021
import com.into.websoso.core.common.util.clickableWithoutRipple
2122
import com.into.websoso.core.designsystem.theme.Black
2223
import com.into.websoso.core.designsystem.theme.WebsosoTheme
24+
import com.into.websoso.core.designsystem.theme.White
2325

2426
@Composable
2527
fun NotificationAppBar(
@@ -28,6 +30,7 @@ fun NotificationAppBar(
2830
) {
2931
Row(
3032
modifier = modifier
33+
.background(White)
3134
.fillMaxWidth()
3235
.padding(horizontal = 6.dp)
3336
.height(44.dp),

app/src/main/java/com/into/websoso/ui/notificationDetail/NotificationDetailActivity.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import androidx.activity.ComponentActivity
77
import androidx.activity.addCallback
88
import androidx.activity.compose.setContent
99
import androidx.activity.viewModels
10+
import com.into.websoso.core.common.util.setupWhiteStatusBar
1011
import com.into.websoso.core.designsystem.theme.WebsosoTheme
1112
import dagger.hilt.android.AndroidEntryPoint
1213

@@ -16,6 +17,8 @@ class NotificationDetailActivity : ComponentActivity() {
1617

1718
override fun onCreate(savedInstanceState: Bundle?) {
1819
super.onCreate(savedInstanceState)
20+
this.setupWhiteStatusBar()
21+
1922
handleBackPressed()
2023

2124
setContent {

app/src/main/java/com/into/websoso/ui/notificationDetail/NotificationDetailScreen.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.into.websoso.ui.notificationDetail
22

3+
import androidx.compose.foundation.background
34
import androidx.compose.foundation.layout.Column
45
import androidx.compose.foundation.layout.fillMaxSize
56
import androidx.compose.runtime.Composable
@@ -8,6 +9,7 @@ import androidx.compose.ui.Modifier
89
import androidx.compose.ui.tooling.preview.Preview
910
import androidx.lifecycle.compose.collectAsStateWithLifecycle
1011
import com.into.websoso.core.designsystem.theme.WebsosoTheme
12+
import com.into.websoso.core.designsystem.theme.White
1113
import com.into.websoso.data.model.NotificationDetailEntity
1214
import com.into.websoso.ui.notification.component.NotificationAppBar
1315
import com.into.websoso.ui.notificationDetail.component.NotificationDetailContent
@@ -21,7 +23,11 @@ fun NotificationDetailScreen(
2123
) {
2224
val uiState by viewModel.notificationDetailUiState.collectAsStateWithLifecycle()
2325

24-
Column(modifier = modifier.fillMaxSize()) {
26+
Column(
27+
modifier = modifier
28+
.fillMaxSize()
29+
.background(White),
30+
) {
2531
NotificationAppBar(onBackButtonClick)
2632
NotificationDetailContent(
2733
uiState = uiState,

0 commit comments

Comments
 (0)