Commit 2a16266
committed
fix: address remaining PR review comments
Complete all remaining review feedback:
1. Restore handle_shift_tab() fallback behavior
- Now handles non-list lines by removing indentation
- Matches original implementation behavior
- Provides consistent behavior for users
2. Fix handle_backspace() line deletion bug
- Use atomic nvim_buf_set_lines() to avoid line number shifts
- Prevents race condition when joining lines
3. Enhanced API documentation
- Added detailed docstrings for get_next_marker()
- Added detailed docstrings for get_previous_marker()
- Clarified behavior for different list types
- Improved parameter and return value descriptions
4. Clarified is_list_breaking_line() comment
- Added comment explaining non-list content (headers, paragraphs)
- Makes logic more explicit
All 169 tests passing. No lint errors.1 parent 9aa9c0c commit 2a16266
3 files changed
Lines changed: 25 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
115 | 127 | | |
116 | 128 | | |
117 | 129 | | |
| |||
155 | 167 | | |
156 | 168 | | |
157 | 169 | | |
158 | | - | |
159 | | - | |
| 170 | + | |
160 | 171 | | |
161 | 172 | | |
162 | 173 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
162 | | - | |
163 | | - | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
164 | 166 | | |
165 | 167 | | |
166 | 168 | | |
| |||
187 | 189 | | |
188 | 190 | | |
189 | 191 | | |
190 | | - | |
191 | | - | |
192 | | - | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
193 | 197 | | |
194 | 198 | | |
195 | 199 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
32 | 34 | | |
33 | 35 | | |
34 | 36 | | |
| |||
0 commit comments