feat(tables): add phase 2 table features#114
Merged
YousefHadder merged 4 commits intomainfrom Nov 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Phase 2 table manipulation features to markdown-plus.nvim, introducing advanced table operations beyond basic CRUD. The changes include cell operations (alignment toggling, clearing), row/column movement, table transformations (transpose, sort), and format conversion (CSV ↔ table).
- Cell operations: toggle alignment, clear content
- Row/column movement: swap with adjacent rows/columns
- Advanced operations: transpose, sort by column (numeric/alphabetic)
- Format conversion: bidirectional CSV ↔ markdown table conversion
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/minimal_init.lua | Improved test environment setup with better plenary.nvim discovery and explicit plugin loading |
| spec/markdown-plus/table_spec.lua | Added comprehensive test coverage for Phase 2 table manipulation features |
| lua/markdown-plus/types.lua | Added confirm_destructive configuration field for destructive operations |
| lua/markdown-plus/table/manipulation.lua | Implemented cell alignment, row/column movement, and cell clearing operations |
| lua/markdown-plus/table/keymaps.lua | Registered keymaps and <Plug> mappings for new table operations |
| lua/markdown-plus/table/init.lua | Exposed new table manipulation functions in the public API |
| lua/markdown-plus/table/conversion.lua | New module for CSV/table format conversion with proper quoting/escaping |
| lua/markdown-plus/table/calculator.lua | New module for transpose and sort operations with numeric detection |
| lua/markdown-plus/config/validate.lua | Added validation for confirm_destructive configuration option |
| doc/markdown-plus.txt | Documented new keymaps and configuration option |
| README.md | Updated documentation with new keymaps and configuration |
c398afb to
18ea9fe
Compare
YousefHadder
added a commit
that referenced
this pull request
Nov 8, 2025
This was referenced Nov 8, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Phase 2 table features including:
All features include:
Quality checks: