feat(image link): add comprehensive image link support#123
Merged
YousefHadder merged 1 commit intomainfrom Nov 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive image link support to markdown-plus.nvim, providing insert, edit, selection conversion, and toggle operations for Markdown image syntax ().
- Implements full image link management with smart detection of images with/without title attributes
- Adds 4 new keymaps for image operations in normal and visual modes
- Updates configuration, types, validation, and comprehensive documentation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/markdown-plus/images_spec.lua | New test file with 39 tests covering pattern matching, cursor detection, toggling, and edge cases; includes placeholder tests for user input functions |
| lua/markdown-plus/types.lua | Adds images boolean field to feature configuration types |
| lua/markdown-plus/init.lua | Integrates images module into plugin initialization and autocmd setup |
| lua/markdown-plus/images/init.lua | New 386-line module implementing all image link operations with patterns, keymaps, and user input functions |
| lua/markdown-plus/config/validate.lua | Adds validation for images feature flag |
| doc/markdown-plus.txt | Adds comprehensive vimdoc section with usage examples and keymap documentation |
| README.md | Adds feature overview, detailed examples, configuration options, and keymap reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
Summary
Adds full support for Markdown image links with insert, edit, selection conversion, and toggle operations.
Features
<leader>mLto insert new image with alt text, URL, and optional title<leader>mLto convert to image link<leader>mEto edit existing image (alt, URL, title)<leader>mAto convert between regular links and image linksImplementation
lua/markdown-plus/images/init.luawith 387 linesTesting
Documentation